chore: add .net version in agent header (#167)

momentohq · Sep 20, 2022 · ef90032 · ef90032
1 parent 10c543f
commit ef90032
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/Momento.Sdk/Internal/ControlGrpcManager.cs b/src/Momento.Sdk/Internal/ControlGrpcManager.cs
@@ -12,13 +12,14 @@ internal sealed class ControlGrpcManager : IDisposable
 {
     private readonly GrpcChannel channel;
     public ScsControl.ScsControlClient Client { get; }
-    private readonly string version = "csharp:" + GetAssembly(typeof(Momento.Sdk.Responses.CacheGetResponse)).GetName().Version.ToString();
+    private readonly string version = "dotnet:" + GetAssembly(typeof(Momento.Sdk.Responses.CacheGetResponse)).GetName().Version.ToString();
+    private readonly string runtimeVersion = "dotnet:" + System.Environment.Version;
 
     public ControlGrpcManager(string authToken, string endpoint)
     {
         var uri = $"https://{endpoint}";
         this.channel = GrpcChannel.ForAddress(uri, new GrpcChannelOptions() { Credentials = ChannelCredentials.SecureSsl });
-        List<Header> headers = new List<Header> { new Header(name: Header.AuthorizationKey, value: authToken), new Header(name: Header.AgentKey, value: version) };
+        List<Header> headers = new List<Header> { new Header(name: Header.AuthorizationKey, value: authToken), new Header(name: Header.AgentKey, value: version), new Header(name: Header.RuntimeVersionKey, value: runtimeVersion) };
         CallInvoker invoker = channel.Intercept(new HeaderInterceptor(headers));
         Client = new ScsControl.ScsControlClient(invoker);
     }

diff --git a/src/Momento.Sdk/Internal/DataGrpcManager.cs b/src/Momento.Sdk/Internal/DataGrpcManager.cs
@@ -13,13 +13,14 @@ public class DataGrpcManager : IDisposable
     private readonly GrpcChannel channel;
     public Scs.ScsClient Client { get; }
 
-    private readonly string version = "csharp:" + GetAssembly(typeof(Momento.Sdk.Responses.CacheGetResponse)).GetName().Version.ToString();
+    private readonly string version = "dotnet:" + GetAssembly(typeof(Momento.Sdk.Responses.CacheGetResponse)).GetName().Version.ToString();
+    private readonly string runtimeVersion = "dotnet:" + System.Environment.Version;
 
     internal DataGrpcManager(string authToken, string host)
     {
         var url = $"https://{host}";
         this.channel = GrpcChannel.ForAddress(url, new GrpcChannelOptions() { Credentials = ChannelCredentials.SecureSsl });
-        List<Header> headers = new List<Header> { new Header(name: Header.AuthorizationKey, value: authToken), new Header(name: Header.AgentKey, value: version) };
+        List<Header> headers = new List<Header> { new Header(name: Header.AuthorizationKey, value: authToken), new Header(name: Header.AgentKey, value: version), new Header(name: Header.RuntimeVersionKey, value: runtimeVersion) };
         CallInvoker invoker = this.channel.Intercept(new HeaderInterceptor(headers));
         Client = new Scs.ScsClient(invoker);
     }

diff --git a/src/Momento.Sdk/Internal/HeaderInterceptor.cs b/src/Momento.Sdk/Internal/HeaderInterceptor.cs
@@ -10,7 +10,8 @@ class Header
 {
     public const string AuthorizationKey = "Authorization";
     public const string AgentKey = "Agent";
-    public readonly List<string> onceOnlyHeaders = new List<string> { Header.AgentKey };
+    public const string RuntimeVersionKey = "Runtime_Version";
+    public readonly List<string> onceOnlyHeaders = new List<string> { Header.AgentKey, Header.RuntimeVersionKey };
     public string Name;
     public string Value;
     public Header(String name, String value)