-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add .net version in agent header #167
Conversation
We need to track two versions: (1) SDK assembly version number and (2) .NET runtime version. I believe the previous commit was tracking the SDK version number (1). We still need to do that in addition to what you've added here, which addresses (2). |
@malandis |
@poppoerika yes, @malandis is right, we want both. And you are right that we will want to make this consistent across the SDKs but we can tackle that after we get dotnet SDK to 1.0. So I think we need to make a call on whether we add this as a second header, or just append it to the value string for the existing header. I can start a thread in engineering about that. |
7d1dacf
As per the conversations here, I added the second header MR2 would be updated afterwards to process the second header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
.NET version was already included in agent header, but I updated the agent string from
csharp:
todotnet:
and version API.I added a chart, SDK Agent/Version, on the bottom of this dashboard: https://app.lightstep.com/momento-preprod/dashboard/mr2-overview-do-not-touch/bb7bWC2V?time_window=minutes_60&sort=sdk_type_version.desc
You can observe
cutomer_id = [email protected]
andsdk_type_version = dotnet:6.0.9
Closes #156