feat: list push, pop, and fetch #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we also add more extension methods to convert `IEnumerable<byte[]>` and `IEnumerable<string>` to `IEnumerable<ByteArray>`.
We will expose a `Concatenate` API to serve this need.
Many data structures have `Get` operations that retrieve a unary value with a status. The data and accessors are exactly the same as for the primitive `CacheGetStatus`. To reduce code duplication, we refactor the common data and behavior into a base class and derive from that.
malandis
requested review from
bruuuuuuuce,
anp13,
eaddingtonwhite and
kvcache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ListPushFrontAsync,ListPushBackAsync,ListPopFrontAsync,ListPopBackAsync,ListFetchAsyncto incubating client.This PR adds the above methods, tests, and documentation to the client.
We also refactored various unary get response classes to inherit from a common base. In the case of simple
Get,DictionaryGet, andListPop, the state and behavior of unary get responses are the same; the only differences lay in building the response object from the various gRPC response messages.Closes #110