Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: list push, pop, and fetch #115

Merged
merged 13 commits into from
Aug 24, 2022
Merged

feat: list push, pop, and fetch #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
09a9e71
Bump protos version.
malandis Aug 22, 2022
59b2cdd
Implement ListPushFront and ListFetch. Test ListFetch.
malandis Aug 22, 2022
8bb6e45
Test `ListPushFront`.
malandis Aug 23, 2022
e62f07d
Implement and test `ListPushFrontBatch`.
malandis Aug 23, 2022
d85f730
Remove `ListPushFrontBatch` methods.
malandis Aug 23, 2022
fd045cc
Add `ListPushFrontAsync` tests to exercise push happy path semantics
malandis Aug 23, 2022
d08df06
Implement `ListPushBackAsync` and test.
malandis Aug 23, 2022
5111431
Implement and test `ListPopFront`.
malandis Aug 23, 2022
faaf73c
Improve `ListPopFront` test to disambiguate popping front vs back
malandis Aug 23, 2022
c282339
Implement and test `ListPopBack`.
malandis Aug 23, 2022
fb35067
Refactor unary get responses.
malandis Aug 23, 2022
0cf5d3b
Document list methods.
malandis Aug 23, 2022
a136579
Bump to latest protos.
malandis Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions IncubatingIntegrationTest/DictionaryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,10 +472,10 @@ public async Task DictionaryFetchAsync_HasContentString_HappyPath()
await client.DictionarySetAsync(cacheName, dictionaryName, field1, value1, true, ttlSeconds: 10);
await client.DictionarySetAsync(cacheName, dictionaryName, field2, value2, true, ttlSeconds: 10);

var getAllResponse = await client.DictionaryFetchAsync(cacheName, dictionaryName);
var fetchResponse = await client.DictionaryFetchAsync(cacheName, dictionaryName);

Assert.Equal(CacheGetStatus.HIT, getAllResponse.Status);
Assert.Equal(getAllResponse.StringDictionary(), contentDictionary);
Assert.Equal(CacheGetStatus.HIT, fetchResponse.Status);
Assert.Equal(fetchResponse.StringDictionary(), contentDictionary);
}

[Fact]
Expand All @@ -494,17 +494,17 @@ public async Task DictionaryFetchAsync_HasContentByteArray_HappyPath()
await client.DictionarySetAsync(cacheName, dictionaryName, field1, value1, true, ttlSeconds: 10);
await client.DictionarySetAsync(cacheName, dictionaryName, field2, value2, true, ttlSeconds: 10);

var getAllResponse = await client.DictionaryFetchAsync(cacheName, dictionaryName);
var fetchResponse = await client.DictionaryFetchAsync(cacheName, dictionaryName);

Assert.Equal(CacheGetStatus.HIT, getAllResponse.Status);
Assert.Equal(CacheGetStatus.HIT, fetchResponse.Status);

// Exercise byte array dictionary structural equality comparer
Assert.True(getAllResponse.ByteArrayDictionary!.ContainsKey(field1));
Assert.True(getAllResponse.ByteArrayDictionary!.ContainsKey(field2));
Assert.Equal(2, getAllResponse.ByteArrayDictionary!.Count);
Assert.True(fetchResponse.ByteArrayDictionary!.ContainsKey(field1));
Assert.True(fetchResponse.ByteArrayDictionary!.ContainsKey(field2));
Assert.Equal(2, fetchResponse.ByteArrayDictionary!.Count);

// Exercise DictionaryEquals extension
Assert.True(getAllResponse.ByteArrayDictionary!.DictionaryEquals(contentDictionary));
Assert.True(fetchResponse.ByteArrayDictionary!.DictionaryEquals(contentDictionary));
}

[Theory]
Expand Down
Loading