feat: reference protos from NuGet #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
approved these changes
Aug 5, 2022
kvcache
reviewed
Aug 5, 2022
| @@ -19,7 +19,7 @@ | |||
| <PackageReference Include="Google.Protobuf" Version="3.19.0" /> | |||
| <PackageReference Include="Grpc.Net.Client" Version="2.40.0" /> | |||
| <PackageReference Include="Grpc.Core" Version="2.41.1" /> | |||
| <PackageReference Include="Momento" Version="0.23.0" /> | |||
| <PackageReference Include="Momento.Protos" Version="0.23.1" /> | |||
There was a problem hiding this comment.
Can you help me understand where this is coming from? I expected to find it here: https://www.nuget.org/packages?q=Momento.Protos
There was a problem hiding this comment.
It's unlisted for now but you can still reference the package.
There was a problem hiding this comment.
Why?
➜ csharp-load git:(main) ✗ dotnet add package Momento.Protos --version 0.23.1
Determining projects to restore...
Writing /var/folders/0x/j_vkq4_13fs687vz8r530kr40000gn/T/tmpOYy9wX.tmp
info : Adding PackageReference for package 'Momento.Protos' into project '/Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj'.
info : Restoring packages for /Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj...
info : GET https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Momento.Protos'&semVerLevel=2.0.0
info : GET https://api.nuget.org/v3-flatcontainer/momento.protos/index.json
info : OK https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Momento.Protos'&semVerLevel=2.0.0 405ms
info : OK https://api.nuget.org/v3-flatcontainer/momento.protos/index.json 128ms
info : GET https://api.nuget.org/v3-flatcontainer/momento.protos/0.23.1/momento.protos.0.23.1.nupkg
info : OK https://api.nuget.org/v3-flatcontainer/momento.protos/0.23.1/momento.protos.0.23.1.nupkg 65ms
info : GET https://api.nuget.org/v3-flatcontainer/grpc/index.json
info : GET https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Grpc'&semVerLevel=2.0.0
info : OK https://api.nuget.org/v3-flatcontainer/grpc/index.json 128ms
info : OK https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Grpc'&semVerLevel=2.0.0 127ms
info : GET https://api.nuget.org/v3-flatcontainer/grpc/2.41.1/grpc.2.41.1.nupkg
info : OK https://api.nuget.org/v3-flatcontainer/grpc/2.41.1/grpc.2.41.1.nupkg 114ms
info : Installed Grpc 2.41.1 from https://api.nuget.org/v3/index.json with content hash kRUkybQ/3G1m+H1nZcNMJ/FQ63S5u/Mo9HRzJG4iPjSt4WWU4F2MZpD2lRu6FSNKDFXas/QQPHRNfEsBmzm4dA==.
info : Installed Momento.Protos 0.23.1 from https://api.nuget.org/v3/index.json with content hash pYKAQpAK/qYelxvogz1hAv1uiwAhANXV5lwzn+yTXXBTAdyx3XWqaKg1NvzhxRv3tk4jeJEUOB8Q1EpsTSoqYg==.
info : Package 'Momento.Protos' is compatible with all the specified frameworks in project '/Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj'.
info : PackageReference for package 'Momento.Protos' version '0.23.1' added to file '/Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj'.
info : Writing assets file to disk. Path: /Users/kenny/gits/csharp-load/obj/project.assets.json
log : Restored /Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj (in 1.08 sec).
kvcache
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull the gRPC generated messages and client from NuGet.