Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reference protos from NuGet #97

Merged
merged 1 commit into from
Aug 5, 2022
Merged

feat: reference protos from NuGet #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Momento/MomentoSdk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<None Remove="Momento" />
<None Remove="Momento.Protos" />
<None Remove="Google.Protobuf" />
<None Remove="Grpc.Net.Client" />
<None Remove="Grpc.Core" />
Expand All @@ -19,7 +19,7 @@
<PackageReference Include="Google.Protobuf" Version="3.19.0" />
<PackageReference Include="Grpc.Net.Client" Version="2.40.0" />
<PackageReference Include="Grpc.Core" Version="2.41.1" />
<PackageReference Include="Momento" Version="0.23.0" />
<PackageReference Include="Momento.Protos" Version="0.23.1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand where this is coming from? I expected to find it here: https://www.nuget.org/packages?q=Momento.Protos

Copy link
Contributor Author

@malandis malandis Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unlisted for now but you can still reference the package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

➜  csharp-load git:(main) ✗ dotnet add package Momento.Protos --version 0.23.1                                                    
  Determining projects to restore...
  Writing /var/folders/0x/j_vkq4_13fs687vz8r530kr40000gn/T/tmpOYy9wX.tmp
info : Adding PackageReference for package 'Momento.Protos' into project '/Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj'.
info : Restoring packages for /Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj...
info :   GET https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Momento.Protos'&semVerLevel=2.0.0
info :   GET https://api.nuget.org/v3-flatcontainer/momento.protos/index.json
info :   OK https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Momento.Protos'&semVerLevel=2.0.0 405ms
info :   OK https://api.nuget.org/v3-flatcontainer/momento.protos/index.json 128ms
info :   GET https://api.nuget.org/v3-flatcontainer/momento.protos/0.23.1/momento.protos.0.23.1.nupkg
info :   OK https://api.nuget.org/v3-flatcontainer/momento.protos/0.23.1/momento.protos.0.23.1.nupkg 65ms
info :   GET https://api.nuget.org/v3-flatcontainer/grpc/index.json
info :   GET https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Grpc'&semVerLevel=2.0.0
info :   OK https://api.nuget.org/v3-flatcontainer/grpc/index.json 128ms
info :   OK https://momento.jfrog.io/artifactory/api/nuget/nuget-public/FindPackagesById()?id='Grpc'&semVerLevel=2.0.0 127ms
info :   GET https://api.nuget.org/v3-flatcontainer/grpc/2.41.1/grpc.2.41.1.nupkg
info :   OK https://api.nuget.org/v3-flatcontainer/grpc/2.41.1/grpc.2.41.1.nupkg 114ms
info : Installed Grpc 2.41.1 from https://api.nuget.org/v3/index.json with content hash kRUkybQ/3G1m+H1nZcNMJ/FQ63S5u/Mo9HRzJG4iPjSt4WWU4F2MZpD2lRu6FSNKDFXas/QQPHRNfEsBmzm4dA==.
info : Installed Momento.Protos 0.23.1 from https://api.nuget.org/v3/index.json with content hash pYKAQpAK/qYelxvogz1hAv1uiwAhANXV5lwzn+yTXXBTAdyx3XWqaKg1NvzhxRv3tk4jeJEUOB8Q1EpsTSoqYg==.
info : Package 'Momento.Protos' is compatible with all the specified frameworks in project '/Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj'.
info : PackageReference for package 'Momento.Protos' version '0.23.1' added to file '/Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj'.
info : Writing assets file to disk. Path: /Users/kenny/gits/csharp-load/obj/project.assets.json
log  : Restored /Users/kenny/gits/csharp-load/momento-csharp-load-generator.csproj (in 1.08 sec).

<PackageReference Include="JWT" Version="8.4.2" />
<PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="6.16.0" />
</ItemGroup>
Expand Down