Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): add option to disable setup python cache #16

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

felix11h
Copy link
Contributor

These changes allow our merge-checks action to use action-setup-python-poetry, see moneymeets/action-merge-checks#31.

Caching in setup-python needs to be disabled for merge-checks, as we run into the issue described here, actions/setup-python#361, when we use github.action_path as the working directory.

Test:

Copy link
Contributor

@zyv zyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it all a bit annoying (solution and naming), but it's the best we can do for now, I'm afraid.

Maybe you could put a TODO next to the switch to remove it when the ticket in the action is closed? Thanks!

@felix11h
Copy link
Contributor Author

felix11h commented Oct 30, 2023

Maybe you could put a TODO next to the switch to remove it when the ticket in the action is closed? Thanks!

I have added the comments. I am merging this now, if you still have feedback later, we can make another pull request.

@felix11h
Copy link
Contributor Author

/rebase

@mergealot mergealot force-pushed the feature/add-option-to-disable-setup-python-caching branch from 679c970 to 66eacc3 Compare October 30, 2023 11:54
@felix11h felix11h merged commit e4c3689 into master Oct 30, 2023
3 checks passed
@felix11h felix11h deleted the feature/add-option-to-disable-setup-python-caching branch October 30, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants