Integration: Date Picker [LG-3152] #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae4b58d The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1.97 kB (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
TheSonOfThomp
force-pushed
the
adam/date-picker-lg-3152
branch
2 times, most recently
from
11ca0f2
to
1675ffa
Compare
* reorganize segment tests * create getNewSegmentValueFromArrowKeyPress * updates getNewSegmentValueFromInputValue * tests for getNewSegmentValueFromInputValue * only fires change handler for explicit values * lint * Update DateInputSegment.tsx
* fix stories * remove space * update type, does this work?? * wip * fix type * rename ctx to storyContextProps * chromatic updates * change date in interaction test * remove time from story * add withVal date
* add tests * move test
* removes interaction tests from Menu * Moves interaction tests to DatePicker.spec * moves arrow key tests from Input to DatePicker * Update DatePicker.spec.tsx * adds test for typing an invalid date * Update DatePicker.spec.tsx * test up/down input arrow keys on each segment * fix year rollover tests * queryByTestId * Add tests for arrow up/down errors * adds utils * adds error state persistence tests
* getSegmentStateFromRefs * Adds error handling * adds getSegmentStateFromRefs tests * updates how dates rollover * Update DatePicker.spec.tsx * Test errors don't appear from tabbing * setIsDirty. show error only if areAllFilled * Update DateInputBox.tsx
* removes interaction tests from Menu * Moves interaction tests to DatePicker.spec * moves arrow key tests from Input to DatePicker * Update DatePicker.spec.tsx * adds test for typing an invalid date * Update DatePicker.spec.tsx * test up/down input arrow keys on each segment * fix year rollover tests * queryByTestId * Add tests for arrow up/down errors * adds utils * adds error state persistence tests
* add component tests for invalid date * move types * creates InvalidDate * update isValidDate * update checks in getISODateTZ & getISODate * update stories TS * updates getSegmentsFromDate * add test to ensure mocked dates are valid * updates some utils to accept DateType as param * update sameDay check in useDateSegment * updates Context * Update DatePickerInput.tsx * fixes menu TS * updates & tests useDateSegments * Add re-render tests to DateInputBox * Adds DateInputBox test for invalid date * adds invalidDate tests for DatePicker * update builds
Closed
Merged
* LG-3697: Expose value type for useLeafyGreenTable (#2127) * expose value type for useLeafyGreenTable * changeset * Remove unused code * change header value * Squashed commit of the following: commit 5a55659 Merge: 9578ad8 c080ec0 Author: Adam Thompson <[email protected]> Date: Thu Jan 11 11:12:50 2024 -0500 Merge branch 'main' into adam/React17-renderHook commit 9578ad8 Author: Adam Thompson <[email protected]> Date: Thu Jan 11 10:43:18 2024 -0500 Update hooks.spec.tsx commit c080ec0 Author: Sean Park <[email protected]> Date: Wed Jan 10 23:16:32 2024 -0500 LG-3697: Expose value type for useLeafyGreenTable (#2127) * expose value type for useLeafyGreenTable * changeset * Remove unused code * change header value commit 44f32b6 Author: Adam Thompson <[email protected]> Date: Wed Jan 10 17:14:50 2024 -0500 Update config.ts commit 030772e Author: Adam Thompson <[email protected]> Date: Wed Jan 10 15:43:51 2024 -0500 adds docs to Exists commit f7fdbfd Author: Adam Thompson <[email protected]> Date: Wed Jan 10 15:42:57 2024 -0500 moves globToRegex commit 55c3283 Author: Adam Thompson <[email protected]> Date: Wed Jan 10 15:33:41 2024 -0500 adds comment for @ts-expect-error commit ee41597 Author: Adam Thompson <[email protected]> Date: Wed Jan 10 12:32:55 2024 -0500 update testing-lib build script commit f11ddfe Author: Adam Thompson <[email protected]> Date: Wed Jan 10 12:04:59 2024 -0500 updates externalDependencies commit 9b6023b Author: Adam Thompson <[email protected]> Date: Wed Jan 10 11:49:18 2024 -0500 updates dependencies commit f921f8e Author: Adam Thompson <[email protected]> Date: Wed Jan 10 11:30:41 2024 -0500 adds changesets commit f25d2e8 Author: Adam Thompson <[email protected]> Date: Wed Jan 10 11:18:03 2024 -0500 updates hooks & toast tests commit 232d059 Author: Adam Thompson <[email protected]> Date: Wed Jan 10 11:17:52 2024 -0500 Creates `waitForState ` commit 085cad2 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 16:00:33 2024 -0500 update types in RTLOverrides commit 021551d Author: Adam Thompson <[email protected]> Date: Tue Jan 9 15:27:02 2024 -0500 remove `act` warnings commit 9e6e2a9 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 15:21:59 2024 -0500 Updates return value of `useToast.updateToast` commit 7700735 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 15:06:33 2024 -0500 update usage in `hooks` commit 3ce1187 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 14:07:32 2024 -0500 export `act` from @lg-tl commit 5292c24 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 13:53:21 2024 -0500 update usage in toast commit 488ad00 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 13:53:15 2024 -0500 update renderHook imports in basic packages commit b46ad88 Author: Adam Thompson <[email protected]> Date: Tue Jan 9 13:25:08 2024 -0500 adds renderHook override to testing-lib * update dp tests * useControlledValue properly sets isControlled * Update hooks.spec.tsx --------- Co-authored-by: Sean Park <[email protected]>
#2147) * add component tests for invalid date * move types * creates InvalidDate * update isValidDate * update checks in getISODateTZ & getISODate * update stories TS * updates getSegmentsFromDate * add test to ensure mocked dates are valid * updates some utils to accept DateType as param * update sameDay check in useDateSegment * updates Context * Update DatePickerInput.tsx * fixes menu TS * updates & tests useDateSegments * Add re-render tests to DateInputBox * Adds DateInputBox test for invalid date * adds invalidDate tests for DatePicker * adds DateInputBox tests * adds isInvalidDateObject * updates newDateFromSegments * Sets values to `Invalid Date` * run range validation only for valid dates * Update DatePickerInput.tsx * add value debugging to story * Displays Error message for invalid dates * update dateInputBox setValue signature * add more complex error tests * clear error message if value to validate is null * Update DatePickerInput.tsx * re-enable tests * Change story update fn signature to DateInputChangeEventHandler * fix ts * rm flaky tests * improve isNextFocusElementASegment check * fix ts
bruugey
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Creates the Date Picker component
RFC Document: https://docs.google.com/document/d/1HussHpUyylDvQFNlwadxGj8A8ThpO3Uzj_D6HoYY7LQ/
🎟 Jira ticket: https://jira.mongodb.org/browse/LG-3152
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes