useControlledValue updates [LG-3608] #1953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 799a672 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +490 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Aug 25, 2023
shaneeza
reviewed
Aug 25, 2023
shaneeza
reviewed
Aug 29, 2023
TheSonOfThomp
changed the title
TheSonOfThomp
commented
Sep 18, 2023
| expect(current.value).toBe('apple'); | ||
| }); | ||
|
|
||
| test('rerendering from initial undefined sets value and isControlled', async () => { |
There was a problem hiding this comment.
Do we want this case to log an error?
|
Closing for now and will reopen after #1951 is finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
useControlledValueto accept any type.initialValueargument. Used for setting the initial value for uncontrolled components. Without this we may encounter a React error for switching between controlled/uncontrolled inputsonChangeargument to be a simple setter function ((value: T) => void)isControlled,valueand anupdateValuesetter function🧪 How to test changes
See spec file