-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-4444: OverlayContext and useOverlay #2454
Conversation
🦋 Changeset detectedLatest commit: 7d9d104 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d7e4f94
to
b02accb
Compare
Size Change: +1.58 kB (+0.12%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small, mostly nit comments but overall looks great!
packages/leafygreen-provider/src/OverlayContext/OverlayContext.tsx
Outdated
Show resolved
Hide resolved
packages/leafygreen-provider/src/OverlayContext/OverlayContext.tsx
Outdated
Show resolved
Hide resolved
packages/leafygreen-provider/src/OverlayContext/OverlayContext.spec.tsx
Outdated
Show resolved
Hide resolved
…der in LG provider
4a310e8
to
7d9d104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* OverlayContext, useOverlayContext, and OverlayProvider * useOverlay to register, remove, and track isTopMostOverlay * Export overlay context related components and hooks and include provider in LG provider * README and changeset * Fix type and lint * Update registerOverlay logic and use more explicit generic type names
* OverlayContext, useOverlayContext, and OverlayProvider * useOverlay to register, remove, and track isTopMostOverlay * Export overlay context related components and hooks and include provider in LG provider * README and changeset * Fix type and lint * Update registerOverlay logic and use more explicit generic type names
* OverlayContext, useOverlayContext, and OverlayProvider * useOverlay to register, remove, and track isTopMostOverlay * Export overlay context related components and hooks and include provider in LG provider * README and changeset * Fix type and lint * Update registerOverlay logic and use more explicit generic type names
* OverlayContext, useOverlayContext, and OverlayProvider * useOverlay to register, remove, and track isTopMostOverlay * Export overlay context related components and hooks and include provider in LG provider * README and changeset * Fix type and lint * Update registerOverlay logic and use more explicit generic type names
✍️ Proposed changes
OverlayContext
,OverlayProvider
,useOverlayContext
, anduseOverlay
OverlayProvider
inLeafyGreenProvider
🎟 Jira ticket: LG-4444
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changes🧪 How to test changes
Added unit tests