Revert LG-4444: OverlayContext and useOverlay #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stephl3
force-pushed
the
steph/po-revert-overlay-context
branch
from
9205c87
to
f4de3a1
Compare
|
Size Change: -929 B (-0.07%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Comment on lines
-1
to
-5
| --- | ||
| '@leafygreen-ui/leafygreen-provider': minor | ||
| --- | ||
|
|
||
| [LG-4444](https://jira.mongodb.org/browse/LG-4444): Adds `OverlayContext` to track overlays that stack on z-axis. `OverlayProvider` is included in `LeafyGreenProvider`. Adds `useOverlay` hook to register/remove overlays into `OverlayContext`. |
There was a problem hiding this comment.
This hasn't been published, right?
There was a problem hiding this comment.
correct, it has not
TheSonOfThomp
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Prior to moving to the top layer approach for the popover refactor, a react context solution was briefly in-flight. This code was added in PR #2454 but will no longer be used and can now be removed.
🎟 Jira ticket: revert work added for LG-4444
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes