Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-277321: reverted changelog changes #238

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 7, 2024

Proposed changes

Jira ticket: CLOUDP-277321

This PR manually updates the prod changelog to remove the entries related to the invite endpoints.

FYI: This PR also fixes the changelog end-to-end (e2e) tests, which started failing because the newly generated changelog did not include the invite endpoints. As a result, the e2e tests were failing due to a mismatch between the generated changelog and the expected one.

@andreaangiolillo andreaangiolillo marked this pull request as ready for review October 7, 2024 10:09
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner October 7, 2024 10:09
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This PR also fixes the changelog end-to-end (e2e) tests, which started failing because the newly generated changelog did not include the invite endpoints. As a result, the e2e tests were failing due to a mismatch between the generated changelog and the expected one.

e2e tests should not depend on our current changelog right? we can address in the TODO ticket?

@andreaangiolillo andreaangiolillo merged commit e94efd6 into main Oct 7, 2024
8 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-277321 branch October 7, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants