CLOUDP-277321: extend sunset date on e2e spec files #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
reviewed
Oct 7, 2024
| @@ -946,7 +946,7 @@ | |||
| } ], | |||
| "summary" : "Return One Identity Provider by ID", | |||
| "tags" : [ "Federated Authentication" ], | |||
| "x-sunset" : "2025-01-01" | |||
There was a problem hiding this comment.
should we use the same dates from https://github.com/10gen/mms/pull/110515 ?
There was a problem hiding this comment.
maybe we can also add a ticket to add a filter functionality per checker to changelog, so that we could exclude/ignore the removed entries similar to what we use for the exemptions
There was a problem hiding this comment.
No, we shouldn’t do that. These files are used for e2e tests, and if we set that date, the tests will start failing again in 2026.
blva
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the changelog e2e tests to extend the sunset date of the specs used in the e2e tests to 2099.
Conversation: #238 (comment)