Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-274733: Fix flaky test #264

Merged
merged 4 commits into from
Oct 25, 2024
Merged

CLOUDP-274733: Fix flaky test #264

merged 4 commits into from
Oct 25, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Oct 23, 2024

Proposed changes

Jira ticket: CLOUDP-274733

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@@ -89,6 +89,8 @@ func GetValidExemptionsList(exemptionsPath string, ignoreExpiration bool, fs afe
validExemptions = append(validExemptions, exemption)
}
}

log.Printf("Found %d valid exemptions", len(validExemptions))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby: adding few more logs to debug exemptions

@@ -56,6 +56,7 @@ func hideByIDs(entries []*OasDiffEntry, ids []string) ([]*OasDiffEntry, error) {
// hideByExemptions hides entries based on the exemptions
func hideByExemptions(entries []*OasDiffEntry, exemptions []breakingchanges.Exemption) ([]*OasDiffEntry, error) {
exemptionsMarkedHidden := breakingchanges.GetHiddenExemptions(exemptions)
log.Printf("Found %d exemptions marked hidden from the changelog.", len(exemptionsMarkedHidden))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby: adding few more logs to debug exemptions

@blva blva marked this pull request as ready for review October 24, 2024 17:39
@blva blva requested a review from a team as a code owner October 24, 2024 17:39
@blva blva merged commit 5c0890a into main Oct 25, 2024
10 checks passed
@blva blva deleted the CLOUDP-274733 branch October 25, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants