Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-274733: Fix flaky test #264

Merged
merged 4 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/required-spec-validations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '20.x'
- name: Install npm dependencies
uses: nick-fields/retry@v3
with:
timeout_minutes: 10
max_attempts: 3
command: npm install
- name: Download openapi-foas
uses: actions/download-artifact@v4
with:
Expand Down
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "mongodb-openapi",
"description": "MongoDB repository with OpenAPI specification"
}
2 changes: 2 additions & 0 deletions tools/cli/internal/breakingchanges/exemptions.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ func GetValidExemptionsList(exemptionsPath string, ignoreExpiration bool, fs afe
validExemptions = append(validExemptions, exemption)
}
}

log.Printf("Found %d valid exemptions", len(validExemptions))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby: adding few more logs to debug exemptions

return validExemptions, nil
}

Expand Down
1 change: 1 addition & 0 deletions tools/cli/internal/changelog/outputfilter/hide.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ func hideByIDs(entries []*OasDiffEntry, ids []string) ([]*OasDiffEntry, error) {
// hideByExemptions hides entries based on the exemptions
func hideByExemptions(entries []*OasDiffEntry, exemptions []breakingchanges.Exemption) ([]*OasDiffEntry, error) {
exemptionsMarkedHidden := breakingchanges.GetHiddenExemptions(exemptions)
log.Printf("Found %d exemptions marked hidden from the changelog.", len(exemptionsMarkedHidden))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby: adding few more logs to debug exemptions

hiddenEntries := 0
for _, entry := range entries {
if entry.HideFromChangelog {
Expand Down
Loading