propagate OOG from pov and MBIP5 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadkaouk
approved these changes
Sep 13, 2024
RomarQ
reviewed
Sep 16, 2024
| ExitReason::Error(ExitError::OutOfGas), | ||
| Default::default(), | ||
| used_gas, | ||
| U256([gas_limit, 0, 0, 0]), |
There was a problem hiding this comment.
U256 implements From<u64>
Suggested change
| U256([gas_limit, 0, 0, 0]), | |
| U256::from(gas_limit), |
RomarQ
reviewed
Sep 16, 2024
| } | ||
| }) | ||
| // This should always return `Some`, but let's play it safe. | ||
| .expect("STORAGE_OOG not defined") |
There was a problem hiding this comment.
Instead of panic here, even if never expected, we should change the return type to Result and let the caller handle the unexpected behaviour. It is a better design to return the Result instead since this will be used in the runtime.
RomarQ
approved these changes
Sep 16, 2024
gonzamontiel
pushed a commit
that referenced
this pull request
Sep 19, 2024
propagate OOG from pov and MBIP5
TarekkMA
pushed a commit
that referenced
this pull request
Oct 24, 2024
propagate OOG from pov and MBIP5
TarekkMA
pushed a commit
that referenced
this pull request
Oct 25, 2024
propagate OOG from pov and MBIP5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.