propagate OutOfGas to outer call if caused by proof size check or MBIP5 #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
D5-nicetohaveaudit⚠️
WASM runtime size check:Compared to target branchMoonbase runtime: 2188 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2136 KB (no changes) ✅ Compared to latest release (runtime-3102)Moonbase runtime: 2188 KB (+248 KB compared to latest release) Moonbeam runtime: 2140 KB (+240 KB compared to latest release) Moonriver runtime: 2136 KB (+236 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master elois-storage-oog +/- ##
====================================================
Coverage 79.33% 79.33% 0.00%
Files 298 298
Lines 87119 87119
====================================================
Hits 69114 69114
Misses 18005 18005
|
noandrea
added
dependencies
gonzamontiel
previously approved these changes
Sep 16, 2024
test/suites/dev/moonbase/test-gas/test-gas-estimation-subcall-oog.ts
Outdated
Show resolved
Hide resolved
pLabarta
approved these changes
Sep 16, 2024
noandrea
approved these changes
Sep 16, 2024
librelois
added
B7-runtimenoteworthy
noandrea
pushed a commit
that referenced
this pull request
Sep 17, 2024
…P5 (#2950) * update frontier pin * add tests * add snapshot & +1 block delay * test: add gas estimation to babe-lottery3 * appease linter --------- Co-authored-by: Pablo Labarta <[email protected]>
librelois
added
D9-needsaudit👮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
If an evm subcall fail because fo a "proof size OutOfGas" error, make the whole eth transaction revert with OutOfGas error.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
moonbeam-foundation/frontier#225
What value does it bring to the blockchain users?