-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moonbeam to polkadot stable2407 #2932
Open
gonzamontiel
wants to merge
36
commits into
master
Choose a base branch
from
moonbeam-polkadot-stable2407
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add simple wasm size check * only run on pull requests * add Github token to env * fix download dir name * try comparing previous and current runtimes * change master branch with dynamic target branch ref * add comparison to latest release * test with older release * download from release instead of workflow artifact * debug release tag not saved to env * debug some more * use gh cli to get releases instead of git tag * use gh api instead of releases * remove get build id & fix awk parsing * build runtimes with _, releases with - * add comment to PR and format msg * use markdown report & replace comment * cat report & fix comment formatting * add twiggy diff reports as artifacts * use upload v4 & create reports dir * rm: deprecated ::set-output cmd
* add: storage read cost constant * update test-pov * update xcm-v3 tests * update xcm-v4 tests * add storage read gas cost to constants * update test-precompile * load constant in beforeAll * replace gas cost with weight to gas ratio
…use (#2913) * chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc * add RPC method test_skipRelayBlocks * allow Root to resume XCM execution * update moonkit pin * add dev-test that trigger auto-pause of xcm * prettier * dev test auto-pause xcm: remove unused imports & improve test scenario * add pallet-emergency-para-xcm to moonriver * add pallet-emergency-para-xcm to moonbeam * apply review suggestions
* set the block size to 60mln gas for moonbeam * update mbip-5 value in test
* add pallet parameters * XcmFeesAccount * add copyrights * add FeesTreasuryProportion --------- Co-authored-by: Rodrigo Quelhas <[email protected]>
…ential relay slots
WASM runtime size check:Compared to target branchMoonbase runtime: 2196 KB (no changes) ✅ Moonbeam runtime: 2160 KB (no changes) ✅ Moonriver runtime: 2160 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2196 KB (+236 KB compared to latest release) Moonbeam runtime: 2160 KB (+236 KB compared to latest release) Moonriver runtime: 2160 KB (+236 KB compared to latest release) |
gonzamontiel
added
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
breaking
Needs to be mentioned in breaking changes
labels
Sep 5, 2024
This reverts commit 4382107.
* Add XcmRecorder to XcmConfig * Add VersionWrapper to hrmp::COnfig * Remove code from deprecated pallet treasury * Remove code from deprecated DmpQueue * Remove code from deprecated XCMV2
gonzamontiel
requested review from
RomarQ,
librelois,
noandrea,
TarekkMA,
Agusrodri and
ahmadkaouk
September 20, 2024 11:56
RomarQ
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates Moonbeam to Polkadot SDK stable2407.
Starting from this version, the naming of versioning and the release process change as described here: RELEASE.md.
What important points reviewers should know?
Changes that affected us:
xcm-fee-payment-runtime-api
intoxcm-runtime-ap
i ([xcm] runtime api for LocationToAccount conversions paritytech/polkadot-sdk#4857)ApproveOrigin
,OnSlash
,ProposalBond
,ProposalBondMinimum
fields from Treasury pallet's config (more here).cumulus_pallet_dmp_queue
(more here and here)Full list of changes here.
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
See dependency pins:
Evm
: https://github.com/moonbeam-foundation/evm/tree/moonbeam-polkadot-stable2407Frontier
: https://github.com/moonbeam-foundation/polkadot-sdk/tree/moonbeam-polkadot-stable2407Polkadot SDK
: https://github.com/moonbeam-foundation/frontier/tree/moonbeam-polkadot-stable2407Crowdloan rewards
: https://github.com/moonbeam-foundation/crowdloan-rewards/tree/moonbeam-polkadot-stable2407Moonkit
: https://github.com/Moonsong-Labs/moonkit/tree/moonbeam-polkadot-stable2407