Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic secret #574

Merged
merged 34 commits into from
Jul 9, 2022
Merged

feat: dynamic secret #574

merged 34 commits into from
Jul 9, 2022

Conversation

ZLBer
Copy link
Member

@ZLBer ZLBer commented May 17, 2022

What this PR does:

User can reference secrets in their config.json. Layotto will help inject the refered secrets into the component metadata

image

Which issue(s) this PR fixes:

Fixes #472

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@seeflood
Copy link
Member

seeflood commented May 17, 2022

Great!
You can run make format to fix the CI lint issues

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #574 (9e04c75) into main (8aa188f) will decrease coverage by 0.01%.
The diff coverage is 53.06%.

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   60.91%   60.89%   -0.02%     
==========================================
  Files         120      122       +2     
  Lines        6389     6432      +43     
==========================================
+ Hits         3892     3917      +25     
- Misses       2124     2133       +9     
- Partials      373      382       +9     
Impacted Files Coverage Δ
pkg/runtime/runtime.go 59.42% <26.08%> (-1.54%) ⬇️
pkg/runtime/ref/injector.go 66.66% <66.66%> (ø)
pkg/runtime/ref/contianer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa188f...9e04c75. Read the comment docs.

# Conflicts:
#	components/sequencer/types.go
@ZLBer
Copy link
Member Author

ZLBer commented May 29, 2022

@seeflood I remember wrong , i only add dynamic secret&config of sequencer , you can review first , If ok, I will continue to modify other components

@seeflood
Copy link
Member

seeflood commented Jun 3, 2022

@ZLBer ok

configs/config_ref_example.json Outdated Show resolved Hide resolved
components/ref/config.go Outdated Show resolved Hide resolved
pkg/runtime/runtime.go Show resolved Hide resolved
configs/config_ref_example.json Show resolved Hide resolved
configs/config_ref_example.json Outdated Show resolved Hide resolved
pkg/runtime/runtime.go Show resolved Hide resolved
pkg/runtime/runtime.go Show resolved Hide resolved
pkg/runtime/runtime.go Outdated Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. This feature is really useful. Thanks!

@seeflood
Copy link
Member

seeflood commented Jul 7, 2022

I can hep modify the sidebar of the doc site, after this PR is merged

@wenxuwan
Copy link
Member

wenxuwan commented Jul 7, 2022

can you give some notes for reviewer?eg. attach an issue to declare what the pr does

@seeflood
Copy link
Member

seeflood commented Jul 7, 2022

can you give some notes for reviewer?eg. attach an issue to declare what the pr does

Good point. The issue is #472
Let me modify this PR's description

@seeflood
Copy link
Member

seeflood commented Jul 9, 2022

I'm going to merge this PR and use this feature to write a test for #556
You guys can continue reviewing it after merged

@seeflood seeflood merged commit f87a806 into mosn:main Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make Secret API ready for production
5 participants