Add guard around zero width or height #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback if this can be included ? |
AlonMiz
approved these changes
Feb 6, 2019
This was referenced Jul 30, 2019
|
This has been open for a long time, was it just an oversight? |
|
Hello, great plugin. Wondering if this is something that can be merged? |
corrigancd
added a commit
to sirensolutions/Leaflet.heat
that referenced
this pull request
Nov 30, 2020
corrigancd
added a commit
to sirensolutions/Leaflet.heat
that referenced
this pull request
Nov 30, 2020
Implementing this patch - mourner/simpleheat#34
|
Same issue here, is it going to be merged anytime soon? |
victorperezpiqueras
added a commit
to victorperezpiqueras/simpleheat
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in my usage of this via leaflet.heat I have a lifecycle where the canvas can be 0 width or 0 height which is causing getImageData to throw an error.
I placed a guard around the relevant section so this case is covered.
If you can accept this request I will contact the leaflet.heat upstream and ask for them to propagate the update to their release.