-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting Fatal Error when zooming out on map on a Dashboard in Kibana #20423
Comments
cc: @alexfrancoeur |
We are facing the same issue. Any update on this? |
@aaronjcaldwell @thomasneirynck @timroes any idea what might be causing this? |
This error looks to me like maps are failing in case the element they want to draw in is 0 width or 0 height. The visualization infrastructure current doesn't (and never did) prevent a chart from drawing in a 0 width/height container. So if maps are having that issues when drawing into 0 width/height containers, they should check the element size before drawing into it. We could think about making a safe guard against that into the visualization infrastructure, but this might be a larger change effecting all visualizations, so I want to carefully consider that. For actually fixing that issue, I would recommend, that maps will actually check their container before drawing into it, e.g. see the vislib implementation for an example: https://github.com/elastic/kibana/blob/master/src/ui/public/vis/vis_types/vislib_vis_type.js#L64:L66 @elastic/kibana-gis feel free to add me as a reviewer for that PR |
thanks @timroes. This error comes from Leaflet (or maybe heatmap plugin, which is a 3rd party overlay). Leaflet manages the rendering of the canvas, so if we cannot detect the 0x0 size of the DOM-container before Leaflet does (and I don't think the visualization infrastructure currently allows this), we'll have to find another approach. I think this might be a regression, or at least looks similar to #6343, as this was fixed once before. This might be because of upgrading to Leaflet 1.3 which introduces canvas-rendering (and likely the source of the drawImage calls for the tiles). I will look into it, please stay tuned, thx |
@thomasneirynck @timroes thanks for the update. I have an active cloud cluster of mine that does this, so if you need to test against a kibana instance let me know. |
@jvernon214 that's great, thx, I'll ping you if I can't repro here on my end |
cc: @kyreddie |
@jvernon214 was that dashboard an upgrade from an earlier 5.x dashboard? |
@thomasneirynck it was not. It was a fresh 6.3.0 install |
@jvernon214 I'm having some trouble reproducing this on my end (chrome 65/ubuntu 16), trying on master branches and 6.3 release. Can you ping me for details on your cloud instance? (see my github-profile for contact info) thx! |
#20400 might have some additional information on how to reproduce this i.e. maximize other visualizations on the same dashboard |
This issue arises when: 1."Change precision on map zoom" is unchecked It seems to be easiest to reproduce on OSX. We're looking into a more robust fix for this. There are two different work-arounds to avoid the issue:
|
@DBarthe what version of Kibana are you using? |
@alexfrancoeur I'm using 6.5.4. It also happened with 6.5.0. To reproduce, create a dashboard with two visualizations :
Then click on "fullscreen" on the second visualization |
thanks @DBarthe! This sounds like a regression. @elastic/kibana-app & @elastic/kibana-gis it looks like we started some discussions around a PR, but I don't see anything linked. Is this something we can address in 6.x? |
I found this interesting blog on Canvas, possibly a simple fix to the issue? |
I found a workaround for 6.6 that solves this issue Workaround as follows
|
fwiw I think I am hitting this when adding a new ci test to master - #40826 |
This is an issue with the Leaflet heatmap plugin that Kibana uses Leaflet/Leaflet.heat#110. There's actually an outstanding PR that addresses the problem mourner/simpleheat#34 but which has not merged yet. Ideally, we can get this fixed upstream. Please stay tuned thanks. |
I´ve asked around in the issues upstream, I hope something will move there soonish. |
@Dumbaz What version of Kibana are you running? The maps application uses mapbox and does not have this issue. The maps application has been embeddable in dashboard since 7.2 release |
@nreese Thanks for the hint! The cluster in question is still on 6.8 unfortunately, Will keep it in mind for after the upgrade, we plan to go to 7.7 soonish. |
The coordinate map is deprecated and will be removed in the next major release of the stack (8.0). Closing, it's unlikely this will be fixed (it would require a patch in Leaflet heatmap layer pluging, which is no longer maintained). We can always re-open if this issue gathers more traction again. |
The link has changed as I moved to a new blogging platform. Here is the new link - https://blog.taditdash.com/uncaught-indexsizeerror-failed-to-execute-getimagedata-on-canvasrenderingcontext2d-the-source-width-is-0. |
Receiving a Fatal Error when zooming out on the map or using Fit Data Bound. This happens when I am using the map on my dashboard. There is a screenshot attached to see the error.
Errors on the screen:
Build: 17230
at window.onerror (https://fa47af10cc3745419ba22683aeacb14e.us-central1.gcp.cloud.es.io:9243/bundles/commons.bundle.js:3:778104)
The text was updated successfully, but these errors were encountered: