Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve connector documentation #269

Closed
shaunagm opened this issue Jun 2, 2020 · 8 comments
Closed

Improve connector documentation #269

shaunagm opened this issue Jun 2, 2020 · 8 comments
Labels
documentation Work type - improvements or additions to documentation high priority Priority - addressing this is an urgent need for a broad swath of Parsons users
Milestone

Comments

@shaunagm
Copy link
Collaborator

shaunagm commented Jun 2, 2020

The connector documentation to be more consistent. Each connector needs, in order:

  1. an overview, which explains the service that the connector connects to, and summarizes what subsets of endpoints currently are covered.
  2. a detailed guide to getting authentication info.
  3. a "quick start guide" that demonstrates instantiating the connector and using a method.

See the action kit connector documentation for an example of what we're looking for.

This doesn't need to be done by a single person in a single PR - feel free to grab a connector by leaving a comment below and submit the updated docs as its own PR.

Here's the current status of the connector docs (thanks to @rgriff23 for the audit!):

Connector Overview Authentication Guide Quickstart Notes
Action Kit ✔️ ✔️ ✔️
Action Network ✔️ ✔️ ✔️
Airtable ✔️ ✔️ ✔️
AWS: ALL needs a global overview at the top to orient the reader
AWS: Lambda to add to add to add
AWS: S3 ✔️ ✔️ ✔️
AWS: Redshift ✔️ ✔️ ✔️
Azure: Blob Storage ✔️ ✔️ ✔️
Bill.com ✔️ ✔️ ✔️
Braintree ✔️ ✔️ ✔️
Civis ✔️ ✔️ ✔️
Copper ✔️ ✔️ ✔️
CrowdTangle ✔️ ✔️ ✔️
Databases: ALL ✔️
Databases: MySQL ✔️ ✔️ ✔️
Databases: Postgres ✔️ ✔️ ✔️
Databases: Database Sync ✔️ ✔️ ✔️
Facebook Ads ✔️ ✔️ ✔️
FreshDesk ✔️ ✔️ ✔️
Github ✔️ ✔️ ✔️
Google: ALL needs a global overview at the top to orient the reader
Google: Big Query ✔️ to add to add
Google: CloudStorage needs improvement to add to add
Google: Civic ✔️ to add to add
Google: Google Sheets needs improvement needs improvement to add
Hustle ✔️ ✔️ ✔️
MailChimp ✔️ ✔️ ✔️
Mobilize America ✔️ ✔️ ✔️
New/Mode ✔️ ✔️ ✔️
Ngpvan ✔️ ✔️ ✔️
PDI ✔️ ✔️ ✔️
Phone2Action ✔️ ✔️ ✔️
Redash ✔️ ✔️ ✔️
Rock the Vote ✔️ ✔️ ✔️
Salesforce ✔️ ✔️ ✔️
SFTP ✔️ ✔️ ✔️
TargetSmart ✔️ ✔️ ✔️
Twilio ✔️ ✔️ ✔️
TurboVote ✔️ ✔️ ✔️
Zoom ✔️ ✔️ ✔️
@move-coop move-coop deleted a comment from railmeat Jun 16, 2020
@shaunagm shaunagm added the documentation Work type - improvements or additions to documentation label Jun 18, 2020
@shaunagm shaunagm added this to the v0.15.0 milestone Jun 18, 2020
@shaunagm shaunagm added the high priority Priority - addressing this is an urgent need for a broad swath of Parsons users label Jun 18, 2020
@shaunagm shaunagm changed the title Documentation & contributor infastructure improvements (discussion thread) Improve connector documentation Jun 25, 2020
@move-coop move-coop deleted a comment from SorenSpicknall Jun 25, 2020
@move-coop move-coop deleted a comment from pjsier Jun 25, 2020
rgriff23 added a commit to rgriff23/parsons that referenced this issue Jul 16, 2020
eliotst pushed a commit that referenced this issue Jul 21, 2020
* fix typos

* update overview and quickstart according to issue #269

* make kwargs documentation consistent and correct across functions

* comply with flake8

* bugfix

* bugfix

* typo fix

* capitalize Parsons, format env vars as code
@rgriff23
Copy link
Contributor

rgriff23 commented Aug 2, 2020

@shaunagm here is a list of connectors that definitely need work and which aspects require work. I apologize for the delay, I was worried that my initial audit was a bit too quick and dirty, so I went over them more carefully just now.

  • Action Kit: fix typo in Quick Start (it imports VAN rather than ActionKit)
  • Action Network: improve Overview, add Authentication Guide
  • Airtable: add Quick Start
  • Azure: add Authentication Guide
  • Bill.com: improve Overview, add Authentication Guide
  • Braintree: add Authentication Guide
  • Civis: add Overview, add Authentication Guide, add Quick Start
  • Copper: add Quick Start
  • CrowdTangle: improve Overview, add Authentication Guide, add Quick Start
  • Databases: Contains multiple classes and needs a global overview at the top to orient the reader. The documentation surrounding individual classes needs to be audited.
  • FacebookAds: add Quick Start
  • Freshdesk: improve Overview, add Authentication Guide, add Quick Start
  • GitHub: improve Overview
  • Google: Contains multiple classes and needs a global overview at the top to orient the reader. The documentation surrounding individual classes needs to be audited.
  • Hustle: add Authentication Guide
  • Mailchimp: add Authentication Guide
  • Mobilize America: add Authentication Guide, add Quick Start
  • New/Mode: improve Overview, add Authentication Guide
  • PDI: improve Overview (in particular, the entire Overview should not be a single hyperlink)
  • Phone2Action: improve Overview, add Authentication Guide, add Quick Start
  • Redash: improve Overview, add Authentication Guide, add Quick Start
  • Salesfoce: improve Overview, add Authentication Guide, add Quick Start
  • SFTP: improve Overview, add Authentication Guide, add Quick Start
  • TargetSmart: add Authentication Guide, add Quick Start
  • Twilio: add Authentication Guide
  • TurboVote: improve Overview, add Authentication Guide, add Quick Start
  • Zoom: improve Overview, add Authentication Guide

@shaunagm
Copy link
Collaborator Author

shaunagm commented Aug 2, 2020

Thanks @rgriff23! This is amazingly helpful.

@davidpablocohn
Copy link
Contributor

Trying to get started helping, and have been looking at the Google Sheets doc. Setting up/enabling the API on the dev console is non-obvious, but the description of how to do so is probably longer than we want to put in the main doc. Is there an established place for ancillary HowTo docs to go?

@shaunagm
Copy link
Collaborator Author

Is there a web page provided by Google that describes the API process in detail? You could do a 1-3 sentence summary and link out to the longer instructions.

@davidpablocohn
Copy link
Contributor

Not that I have found (though ironically, Googling Google stuff is often a black hole). The best I've found is a third-party description here: https://www.iperiusbackup.net/en/how-to-enable-google-drive-api-and-get-client-credentials/; I'm writing up a quick summary to see how concise I can get it, and will then shop around for a good location.

davidpablocohn added a commit to davidpablocohn/parsons that referenced this issue Sep 25, 2020
eliotst pushed a commit that referenced this issue Sep 29, 2020
* Make GoogleSheets __init__ compatible with other Google API connectors

Retain all original GoogleSheets compatibility, but add ability for it to take a string as its init, same as GoogleBigQuery and GoogleCloudStorage. Also have it look in GOOGLE_APPLICATION_CREDENTIALS for its credentials (after checking it's original env variable GOOGLE_DRIVE_CREDENTIALS).

So it should retain full backward compatibility, and no one currently using it should notice any difference, but it will now also be able to be instantiated using the same calling convention as other Google connectors.

* Revert "Make GoogleSheets __init__ compatible with other Google API connectors"

This reverts commit dc6d2f2.

Should have been pushed to a branch.

* Add Quickstart section to doc for Google connectors

Also clean up internal docstrings for Google connector py files.

* Add short overview to start of google.rst.

Moves toward completion of #269.

* Remove obsolete google_[civic,sheets].html

Their content has been moved into google.html (via google.rst, but the autogenerated files google_civic.html and google_sheets.html) were never removed from repo.

* Force add of .gitignored google.html

* Update Google Drive to Google Service Account
@rgriff23
Copy link
Contributor

rgriff23 commented Oct 6, 2020

@shaunagm Just making a note here that once #411 is merged (it should be ready), the AWS connectors are done. And with @davidpablocohn's PR #417 merged, the Google connectors are done too.

Not sure if you want to close out this issue or keep it open for ongoing improvements to the documentation, but I think the goals outlined in description are achieved! :)

@shaunagm
Copy link
Collaborator Author

shaunagm commented Oct 6, 2020

That's so exciting! Do you have permission to close issues? If so, once 411 is merged, I'll let you do the honors. ;)

@rgriff23
Copy link
Contributor

rgriff23 commented Oct 6, 2020

That's so exciting! Do you have permission to close issues? If so, once 411 is merged, I'll let you do the honors. ;)

@shaunagm Thanks! I am assuming I don't have permissions, because I don't see the 'Close' button (which I think would appear beneath the comment box).

@ChrisC ChrisC closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Work type - improvements or additions to documentation high priority Priority - addressing this is an urgent need for a broad swath of Parsons users
Projects
None yet
Development

No branches or pull requests

5 participants