Docs: Update ActionNetwork. #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgriff23
reviewed
Aug 10, 2020
docs/action_network.rst
Outdated
|
|
||
| an = ActionNetwork(API_TOKEN) | ||
| from parsons import VAN |
There was a problem hiding this comment.
Should import ActionNetwork, not VAN.
I'm guessing this was copied from ActionKit, where I previously introduced this exact typo because I was using the VAN connector as my example. Maybe you can fix the ActionKit bug in your PR too, especially since it is referenced as an example for documentation?
There was a problem hiding this comment.
Good catch. And, yes, your theory is correct.
I've actually got this fixed in the S3 docs PR for AK, so I think that it should be fixed shortly there too.
SorenSpicknall
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves overview and adds authentication.
#269