Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing more boost usage #1372
Removing more boost usage #1372
Changes from 51 commits
22cb249
a9cb84f
af0fed8
90f9e00
245cad5
05ebbb6
256c020
fff4fdd
58f3828
190aa61
47148ff
35fed32
95ce624
d3dddfa
d33b78d
79405c4
25bfad5
4ba40c8
61952bc
d398386
ee04b2c
7d20e56
dd4cda6
97dd35f
051cc11
6a0a154
2f3c9dd
27418ed
46670a2
6499df1
da13641
0a22f2d
03fada2
bff3698
4a1605a
e637955
9780359
a23aff0
d4d3c60
c6bb633
9d587a9
9838529
c73ec20
5a2a694
366db23
9d00f99
3fdf34b
23dcfa0
52a8e1e
405be90
b68050a
68c31b7
669f474
7f1822b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could get rid of this because PI is available from
math.h
. I don't care too much about this suggestion, thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I use
#define _USE_MATH_DEFINES
before includingcmath
ormath.h
, or useadd_definitions(-D_USE_MATH_DEFINES)
(as mentioned here)? Or should we just leave it as using boost? We might be able to remove boost from someCMakeList.txt
s orpackage.xml
s if we change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this stackexchange answer is right, you can just do
#include <math.h>
https://stackoverflow.com/a/1727896
No need to #define anything or add_definitions as far as I can tell since we're targeting newer systems. I could be wrong, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great sounds good, I'll switch to that then. Will now close #1373