Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast of "max_velocity" and "max_acceleration" values to double #2803

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

JorgePRamos
Copy link
Contributor

Description

Propose solution for open issue #2776 which tackles the generation of the joint_limits.yaml by the MoveIt setup assistant in which the generated values are Integers when Double are expected. A cast to double has been made as an attempt to solve this issue in s simple way.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

github-actions bot commented Jun 6, 2024

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Jun 6, 2024
@henningkayser henningkayser added this pull request to the merge queue Jun 14, 2024
Merged via the queue into moveit:main with commit 5c11052 Jun 14, 2024
7 of 9 checks passed
mikeferguson pushed a commit to mikeferguson/moveit2 that referenced this pull request Oct 23, 2024
sjahr pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants