Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce package.xml format 3 Schema #779

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

henningkayser
Copy link
Member

This fixes the formatting for all package.xml files and enforces the format 3 ROS schema.
#697 should be merged first, then I will switch the target to main.

@tylerjw
Copy link
Member

tylerjw commented Nov 15, 2021

@henningkayser I merged the PR this depends on, please rebase this on main (and retarget the PR).

@henningkayser henningkayser changed the title [Don't Merge] Enforce package.xml format 3 Schema Enforce package.xml format 3 Schema Nov 15, 2021
@henningkayser henningkayser changed the base branch from pr-update-maintainers to main November 15, 2021 16:02
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #779 (ee90e84) into main (6cdc62a) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   55.57%   55.59%   +0.03%     
==========================================
  Files         198      198              
  Lines       21420    21420              
==========================================
+ Hits        11901    11907       +6     
+ Misses       9519     9513       -6     
Impacted Files Coverage Δ
...e/collision_detection_fcl/src/collision_common.cpp 74.89% <0.00%> (-0.23%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 46.81% <0.00%> (+0.48%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.93% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdc62a...ee90e84. Read the comment docs.

@tylerjw tylerjw merged commit 65fdd50 into moveit:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants