Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panda controller filenames #343

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Mar 29, 2022

Description

Goes with moveit/moveit_resources#127 (although some of the links were broken anyway)

CC: @AndyZe

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@DLu
Copy link
Contributor Author

DLu commented Mar 29, 2022

(Replacement for #340 )

@DLu DLu requested a review from AndyZe March 29, 2022 14:58
@mergify
Copy link

mergify bot commented Apr 1, 2022

This pull request is in conflict. Could you fix it @DLu?

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this works and you didn't miss any renamings.

Needs to be merged with:

moveit_resources: moveit/moveit_resources#127
moveit2: moveit/moveit2#1163

@DLu DLu force-pushed the update_panda_controllers branch from a17d62c to e8c38ce Compare April 4, 2022 14:28
@DLu
Copy link
Contributor Author

DLu commented Apr 4, 2022

Resolved!

@DLu DLu closed this Apr 5, 2022
@DLu DLu reopened this Apr 5, 2022
@vatanaksoytezer vatanaksoytezer merged commit 1ba524d into moveit:main Apr 5, 2022
@DLu DLu deleted the update_panda_controllers branch April 6, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants