-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update panda controller filenames #1163
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 59.76% 61.03% +1.27%
==========================================
Files 274 274
Lines 24749 24749
==========================================
+ Hits 14789 15102 +313
+ Misses 9960 9647 -313
Continue to review full report at Codecov.
|
moveit_ros/moveit_servo/test/launch/test_servo_pose_tracking.test.py
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/test/launch/move_group_launch_test_common.py
Outdated
Show resolved
Hide resolved
Co-authored-by: David V. Lu!! <[email protected]>
Seems something wrong with rmw implementation in testing. Will investigate
|
Until this PR get merged, everything will be blocked since we merged the moveit_resources PR, which is breaking. If we can't resolve the CI issue in testing, I will add a specific version of moveit_resources. |
I could not replicate this test failure on focal. |
Working on some fixes here: vatanaksoytezer#26 |
Merged with #1170. |
This PR should be merged along with these PR's in other repos:
moveit_resources: moveit/moveit_resources#127
moveit_tutorials: moveit/moveit2_tutorials#343 (comment)
@DLu is leading the charge on this, but I think the idea is to give the arm and the gripper a standard name that makes sense and can be used by Jafar's simplified launch module. Previously both MoveIt and ros_control config files were often named
controller.yaml
.