Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panda controller filenames #1163

Closed
wants to merge 5 commits into from

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Apr 2, 2022

This PR should be merged along with these PR's in other repos:

moveit_resources: moveit/moveit_resources#127
moveit_tutorials: moveit/moveit2_tutorials#343 (comment)

@DLu is leading the charge on this, but I think the idea is to give the arm and the gripper a standard name that makes sense and can be used by Jafar's simplified launch module. Previously both MoveIt and ros_control config files were often named controller.yaml.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #1163 (e01754e) into main (99939d3) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
+ Coverage   59.76%   61.03%   +1.27%     
==========================================
  Files         274      274              
  Lines       24749    24749              
==========================================
+ Hits        14789    15102     +313     
+ Misses       9960     9647     -313     
Impacted Files Coverage Δ
..._core/collision_detection/src/collision_common.cpp 50.00% <0.00%> (-50.00%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 73.76% <0.00%> (+0.23%) ⬆️
moveit_core/robot_state/src/robot_state.cpp 47.28% <0.00%> (+0.32%) ⬆️
moveit_core/planning_scene/src/planning_scene.cpp 48.84% <0.00%> (+0.59%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 67.40% <0.00%> (+2.53%) ⬆️
...or/src/current_state_monitor_middleware_handle.cpp 88.24% <0.00%> (+5.89%) ⬆️
moveit_ros/moveit_servo/src/collision_check.cpp 86.16% <0.00%> (+6.16%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 46.50% <0.00%> (+6.57%) ⬆️
moveit_ros/moveit_servo/src/servo.cpp 75.00% <0.00%> (+12.50%) ⬆️
...anning_scene_monitor/src/current_state_monitor.cpp 75.70% <0.00%> (+20.32%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99939d3...e01754e. Read the comment docs.

Co-authored-by: David V. Lu!! <[email protected]>
@vatanaksoytezer
Copy link
Contributor

Seems something wrong with rmw implementation in testing. Will investigate

    [unittest_planning_context-1] terminate called after throwing an instance of 'rclcpp::exceptions::RCLError'
    [unittest_planning_context-1]   what():  failed to initialize rcl init options: failed to load any RMW implementations, at ./src/functions.cpp:125, at ./src/rcl/init_options.c:75
    ```

@vatanaksoytezer vatanaksoytezer added the help wanted Extra attention is needed label Apr 5, 2022
@vatanaksoytezer
Copy link
Contributor

Until this PR get merged, everything will be blocked since we merged the moveit_resources PR, which is breaking. If we can't resolve the CI issue in testing, I will add a specific version of moveit_resources.

@DLu
Copy link
Contributor

DLu commented Apr 6, 2022

I could not replicate this test failure on focal.

@vatanaksoytezer
Copy link
Contributor

Working on some fixes here: vatanaksoytezer#26

@vatanaksoytezer
Copy link
Contributor

Merged with #1170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants