Switched to moveit's own dockerfile and fixed dependency repos #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies. (rmw_fastrtps, rmw_zenoh, rmw_cyclonedds)
|
Do you think this updates should go to MoveIt2's docker image? Because seems my PR about deprecation warning throws out build error. ( moveit/moveit2#2933 ) |
sjahr
reviewed
Jul 26, 2024
* Used moveit's latest rolling docker image * re-edited underlay workspace in dockerfile
CihatAltiparmak
changed the title
…y workspace alias
|
Cool mention from me to you (@sjahr ) I'm ready for next review! When you are available, would you take a look at it ? Don't mind CI failures. I believe most of them will be fixed with this PR. |
sjahr
approved these changes
Aug 2, 2024
Lets merge this guy then ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rolling, we should upgrade before building workspace due to the fact that rolling is a version that updated continuously. Otherwise docker sometimes can fail. Additionaly, i have fixed some typos in dependency file.