Refactor FXIOS-5488 [v110] Remove deferred from SQLiteHistoryFavicons #12776
Conversation
|
Build is green here |
lmarceau
changed the title
|
Hello, as i don't really understand this discussion above, to say the least ;) Can some of you code wizzards let me know when I'll be able to reconnect my Firefox account on my mobile device? I tried again yesterday and of course it crashed again. Do I need to wait until the next upgrade? And when will that be? It's quite difficult to use Firefox on iphone without passwords. And I don't always have access to computer. Many thanks for your answer. |
|
Hello @Isamas, If there's no existing issue for the problem you're encountering, please create one here |
|
Hello @lmarceau
I don’t understand your request/ demand? I did describe my issue / crashes in the first ticket (which was merged w this one and where I’ve attached crash logs)
So some people here are looking into it …So why should I do another ticket? 🤔
Isabelle Le 3 janv. 2023 à 17:41, lmarceau ***@***.***> a écrit :
Hello @Isamas,
It's preferable to comment on issues rather than pull requests. Is there an existing issue for the problem you are mentioning (you're saying you can't login? or you can't sync?) Other than that, I would normally expect Firefox account to work on mobile.
If there's no existing issue for the problem you're encountering, please create one here
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
If you open the actual link and do not reply from email, you'll see you are at the moment commenting on the Pull request #12776 (where code changes happen) and not on the actual issue. From your comment I am deducing that you're referring to issue #12771. Please do not comment further on the Pull request. Thanks! |
|
Ah ok. Sorry. Tks |
|
@Mergifyio backport release/v109.0 |
✅ Backports have been created
|
…#12776) (#12864) (cherry picked from commit 942509a) Co-authored-by: lmarceau <[email protected]>
|
It seems to work! Many thanks 💝 |
FXIOS-5488 #12773
Looking at #12771, we can't rule out that deferred isn't linked into this crash. Seeing #12527 this also becomes suspicious.
One easy change is to remove deferred from that code in 109. This module is enclosed and so this shouldn't make things worst. Made sure that we call UI code from the main thread. This is a patch in the meantime that we're working on the long term favicon solution.