Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict platformdirs to <4 due to constraints in virtualenv package #867

Closed
wants to merge 1 commit into from
Closed

Restrict platformdirs to <4 due to constraints in virtualenv package #867

wants to merge 1 commit into from

Conversation

bhearsum
Copy link
Contributor

This is due to pypa/virtualenv#2666.

jcristau
jcristau reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platformdirs pin could live in test.in, as far as I can tell, looks like it's pulled in by black in "test" environments, and by virtualenv, via tox, in "local" environments, and "base" isn't affected.

@jcristau jcristau mentioned this pull request Nov 15, 2023
Merged
@bhearsum
Copy link
Contributor Author

May as well just let this get addressed in #869.

@bhearsum bhearsum closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcristau jcristau jcristau left review comments

@ahal ahal ahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhearsum @ahal @jcristau