-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for platformdirs v4 #2666
Comments
I wanted to add that if a library you depend upon requires One such example: |
5565034 was merged already, so this will be resolved whenever the next release happens |
Any rough ETA on when a release would occur? |
Probably later this week, I'm currently in hospital for a few days unexpectedly so things got delayed, sorry. |
All the best @gaborbernat . Any other maintainers that could possibly jump in and help out? |
Nope, sorry. It's been quite a while since I worked on this repo, and I'm not sufficiently familiar with the current release process to want to try to do a release. |
Seems like it's as simple as creating a release on GitHub which will trigger the workflow: https://github.com/pypa/virtualenv/blob/main/.github/workflows/release.yml But we can't be sure so it's probably better to wait for @gaborbernat |
Is more complicated because you need to use https://github.com/pypa/virtualenv/blob/main/tox.ini#L79 to update the changelog first. And then also create a zipapp via https://github.com/pypa/virtualenv/blob/main/tox.ini#L99 and do the release over pypa/get-virtualenv@779ff03 Finally create Github releases for both repos. Out now at https://pypi.org/project/virtualenv/20.24.7/ |
Thank you @gaborbernat! Hope you are doing well. |
Thank you, relatively speaking to last week, I'm better, however, the full recovery will take some more time. |
Thank you, speedy recovery! Might be a good idea to document this release process in the contribution/maintainer docs |
Just to be clear, while I still have maintainer rights here, I wouldn't have done an emergency release for this even if the process had been documented. I don't think it's unreasonable for there to be a week or two's delay on something like this if the lead maintainer is unavailable. (Pip, for example, only does a release every 3 months). I agree that having the various project processes documented is a good thing to do, but let's keep things in perspective here. Best wishes for your recovery @gaborbernat! |
@pfmoore I did not intend to imply that you should have. Just always helps to have things documented for critical packages just in case 👍 |
virtualenv have added support for platformdirs 4.0 see pypa/virtualenv#2666 so we can remove our pins
platformdirs v4.0
was released yesterday, yet virtualenv requiresplatformdirs<4
. Please update virtualenv to accept the latest version of platformdirs.The text was updated successfully, but these errors were encountered: