Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do all pre-loading with redux-saga, not redux-async-connect #10365

Closed
kumar303 opened this issue May 8, 2017 · 2 comments · Fixed by mozilla/addons-frontend#3974
Closed

Do all pre-loading with redux-saga, not redux-async-connect #10365

kumar303 opened this issue May 8, 2017 · 2 comments · Fixed by mozilla/addons-frontend#3974
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend

Comments

@kumar303
Copy link
Contributor

kumar303 commented May 8, 2017

Once we have redux-saga, we can do all data pre-loading in a saga. This should allow us to convert all historic asyncConnect() decorators into sagas and remove redux-async-connect. We also need to remove redux-async-connect if we want to migrate to react-router 4.
@kumar303 kumar303 self-assigned this May 8, 2017
@kumar303 kumar303 mentioned this issue May 11, 2017
Closed
@kumar303 kumar303 mentioned this issue May 25, 2017
Closed
@kumar303 kumar303 mentioned this issue May 5, 2024
Closed
This was referenced May 5, 2024
Closed
Closed
This was referenced Jul 11, 2017
Closed
Closed
@tofumatt
Copy link
Contributor

Will fix mozilla/addons-frontend#2269.

This was referenced May 5, 2024
Closed
Closed
@tofumatt tofumatt assigned tofumatt and unassigned kumar303 Aug 15, 2017
tofumatt referenced this issue in mozilla/addons-frontend Aug 15, 2017
@tofumatt
docs: Remove async-connect info from docs (#2356)
9f33860
tofumatt referenced this issue in mozilla/addons-frontend Aug 15, 2017
@tofumatt
WIP: chore: Remove redux-connect (fix #2356)
57fe64a
@tofumatt tofumatt mentioned this issue Aug 15, 2017
Closed
@tofumatt
Copy link
Contributor

I have this part-way finished but I'm just gonna bump it one milestone to focus on getting a few more product-y feature-y patches in.

@kumar303 kumar303 mentioned this issue Sep 11, 2017
Closed
tofumatt referenced this issue in mozilla/addons-frontend Sep 18, 2017
@tofumatt
WIP: chore: Remove redux-connect (fix #2356)
4d8bd81
tofumatt referenced this issue in mozilla/addons-frontend Sep 20, 2017
@tofumatt
WIP: chore: Remove redux-connect (fix #2356)
90e85d4
@willdurand willdurand mentioned this issue Nov 24, 2017
Merged
@tofumatt tofumatt removed their assignment Nov 27, 2017
@KevinMind KevinMind added migration:no-jira repository:addons-frontend Issue relating to addons-frontend labels May 5, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove asnyc-connect (redux-connect) and add react-router-redux
5 participants
@muffinresearch @kumar303 @tofumatt @addons-robot @KevinMind