Bug 1742448 - Allow passing in the build date #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
with-build-date
branch
from
942529e
to
f1829e9
Compare
badboy
force-pushed
the
with-build-date
branch
4 times, most recently
from
a0cd60e
to
64e851b
Compare
badboy
force-pushed
the
with-build-date
branch
4 times, most recently
from
9eb58ab
to
70409b7
Compare
|
Adding multiple reviewers, whoever gets here first. |
travis79
approved these changes
Jan 10, 2022
gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
Previously a second invocation of Glean.initialize would override the stored build info, even if no other work was done due to Glean already being initialized.
badboy
force-pushed
the
with-build-date
branch
from
70409b7
to
78106d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
- Coverage 30.30% 29.41% -0.90%
==========================================
Files 1 1
Lines 33 34 +1
==========================================
Hits 10 10
- Misses 23 24 +1
Continue to review full report at Codecov.
|
|
Drop in coverage is expected. We only record coverage from Rust tests and currently the build date is not used from within Rust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mozilla/glean_parser#431 & a release.
Requires mozilla-services/mozilla-pipeline-schemas#715