Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1742448 - Generate build date at invocation time #431

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 6, 2022

Implementation of the build date field in build info.
Will require Glean updates as well.


Draft until proposal is formally accepted.

@badboy badboy marked this pull request as draft January 6, 2022 11:35
@badboy badboy force-pushed the build-date branch 9 times, most recently from 6d44873 to bbcda1c Compare January 6, 2022 15:36
@badboy badboy marked this pull request as ready for review January 7, 2022 13:43
@badboy badboy requested review from brizental and mdboom and removed request for brizental January 10, 2022 13:56
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind filing follow up bugs to implement this for other languages?

glean_parser/swift.py Show resolved Hide resolved
glean_parser/util.py Show resolved Hide resolved
glean_parser/swift.py Show resolved Hide resolved
@badboy
Copy link
Member Author

badboy commented Jan 11, 2022

@badboy badboy merged commit 9dd0bdd into mozilla:main Jan 12, 2022
@badboy badboy deleted the build-date branch January 12, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants