Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning due to invalid escape sequences #609

Closed
tirkarthi opened this issue Jul 29, 2020 · 17 comments
Closed

Deprecation warning due to invalid escape sequences #609

tirkarthi opened this issue Jul 29, 2020 · 17 comments

Comments

@tirkarthi
Copy link

Deprecation warnings are raised due to invalid escape sequences. This can be fixed by using raw strings or escaping the literals. pyupgrade also helps in automatic conversion : https://github.com/asottile/pyupgrade/

find . -iname '*.py' | grep -Ev 'vendor|example|doc|tools|sphinx' | xargs -P4 -I{} python3.8 -Wall -m py_compile {}
./setup.py:21: DeprecationWarning: invalid escape sequence \d
  return re.findall("__version__ = '([\d\.]+)'",
@whimboo
Copy link
Contributor

whimboo commented Aug 14, 2020

Thank you for the report. @tirkarthi, would you be also interested to get this issue fixed?

@tanmoydas9166
Copy link

Can I fix this issue?

@tirkarthi
Copy link
Author

@tanmoydas9166 Feel free to pick it up.

tanmoydas9166 added a commit to tanmoydas9166/mozdownload that referenced this issue Aug 18, 2020
@tanmoydas9166
Copy link

tanmoydas9166 commented Aug 18, 2020

Sir, please check my PR. @whimboo @tirkarthi

@whimboo
Copy link
Contributor

whimboo commented Aug 27, 2020

@tanmoydas9166 thanks for picking up this issue. I had a look at open PRs but sadly I cannot find the one from you. Did you actually create one? It's not enough to only push the changes to your own fork.

@paridhi7
Copy link

paridhi7 commented Sep 1, 2020

Hi, I'm new to open source. Is this issue still open?

@whimboo
Copy link
Contributor

whimboo commented Sep 8, 2020

I haven't seen a PR being opened by @tanmoydas9166 yet. So feel free to pick-up this issue. Thanks.

tanmoydas9166 added a commit to tanmoydas9166/mozdownload that referenced this issue Sep 8, 2020
@whimboo whimboo mentioned this issue Sep 8, 2020
@sahilsandhu
Copy link

Hi, i am new to open source, is this issue resolved or it is still opened??

@whimboo
Copy link
Contributor

whimboo commented Sep 9, 2020

It's currently being worked on via PR #610. But maybe you want to help with #247.

@rishishounak
Copy link

If the issue is still open could I join in

@whimboo
Copy link
Contributor

whimboo commented Sep 14, 2020

If we don't hear back from @tanmoydas9166 within two days feel free to provide your own PR. Thanks!

@rishishounak
Copy link

I need some guidance to get started as I am new

@whimboo
Copy link
Contributor

whimboo commented Sep 16, 2020

@rishishounak please check #610 for the changes and my review comments. Those will be the lines of code you will have to change. Once done submit a PR. Thanks.

@rishishounak
Copy link

Please check whether I have made the right changes

@tanmaysinghal98
Copy link
Contributor

@whimboo I am a first timer, can I pick this up?

@rishishounak
Copy link

@whimboo please check my pr

@whimboo
Copy link
Contributor

whimboo commented Dec 27, 2020

Fixed by #612.

@whimboo whimboo closed this as completed Dec 27, 2020
@whimboo whimboo added this to the 1.27.0 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants