Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade syntax of setup.py to python 3.8+ #612

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

tanmaysinghal98
Copy link
Contributor

@tanmaysinghal98 tanmaysinghal98 commented Sep 21, 2020

This is a fix for #609
Please take a look and let me know.

Checked with following command

find . -iname '*.py' | grep -Ev 'vendor|example|doc|tools|sphinx' | xargs -P4 -I{} python3.8 -Wall -m py_compile {}

No deprecation warning coming.

@coveralls
Copy link

coveralls commented Sep 21, 2020

Coverage Status

Coverage increased (+0.1%) to 92.918% when pulling 6ddaba2 on tanmaysinghal98:master into 6ccc5a9 on mozilla:master.

@whimboo
Copy link
Contributor

whimboo commented Dec 27, 2020

I'm very sorry that it took so long to review. I now had a look at and compared to the other PRs this is the right solution. Thanks a lot!

@whimboo whimboo merged commit 4bda718 into mozilla:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants