Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Make the text layer focusable before the editors (bug 1881746) #17790

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

calixteman
Copy link
Contributor

Keep the different layers in a constant order to avoid the use of a z-index and a tab-index.

web/annotation_editor_layer_builder.js Outdated Show resolved Hide resolved
web/annotation_layer_builder.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.js Show resolved Hide resolved
web/annotation_layer_builder.js Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/annotation_layer_builder.js Show resolved Hide resolved
web/text_layer_builder.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/ac036192a49fb4e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/719f25935134e4b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/719f25935134e4b/output.txt

Total script time: 7.10 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/ac036192a49fb4e/output.txt

Total script time: 18.74 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the bug1881746 branch 2 times, most recently from a5d45dd to f891803 Compare March 15, 2024 16:18
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/63bc28f51dc71d3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3650e57e7fe1051/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3650e57e7fe1051/output.txt

Total script time: 7.22 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/63bc28f51dc71d3/output.txt

Total script time: 22.78 mins

  • Integration Tests: FAILED

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with one more comment; thanks!

web/annotation_editor_layer_builder.js Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c934614ba73409/output.txt

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e82c93a1ac49535/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4e53b23843fe5d0/output.txt

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not removing the following now dead code:

this.pageDiv = null;

@calixteman
Copy link
Contributor Author

This is still not removing the following now dead code:

this.pageDiv = null;

Sorry, my bad, I thought it was in the ctor.... let me fix that.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/e82c93a1ac49535/output.txt

Total script time: 6.98 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4e53b23843fe5d0/output.txt

Total script time: 19.60 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3b71a7ae15a8d0f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2c66d252456ba0a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3b71a7ae15a8d0f/output.txt

Total script time: 7.00 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/2c66d252456ba0a/output.txt

Total script time: 20.52 mins

  • Integration Tests: FAILED

Keep the different layers in a constant order to avoid the use of a z-index
and a tab-index.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6c1aa288d1e0ae3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/98c7fa6a1f1463e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/6c1aa288d1e0ae3/output.txt

Total script time: 6.81 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/98c7fa6a1f1463e/output.txt

Total script time: 18.97 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit e892f3b into mozilla:master Mar 19, 2024
9 checks passed
@calixteman calixteman deleted the bug1881746 branch March 19, 2024 16:10
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 21, 2024
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 21, 2024
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 21, 2024
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 21, 2024
calixteman added a commit to calixteman/pdf.js that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants