Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to aria-hide the structure tree (bug 1894849) #18044

Merged
merged 1 commit into from
May 6, 2024

Conversation

calixteman
Copy link
Contributor

If one ancestor of the structure tree has the attribute aria-hidden then it's invisible for screen readers.

If one ancestor of the structure tree has the attribute aria-hidden
then it's invisible for screen readers.
@Snuffleupagus
Copy link
Collaborator

Looking at the history that line was added PR #17790, as part of fixing bug 1881746. Since I don't really (at all) know a11y stuff, does removing this line (somehow?) re-introduce part of that bug or was it never actually a "necessary" change?

@calixteman
Copy link
Contributor Author

I don't remember exactly why I added this aria-hidden (I wonder if it could just be a leftover after having tested if adding this attribute was helpful to fix the bug or not).
That said, I tested the patch on a mac with Firefox nightly and VO and it wfm.

@timvandermeij
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6d35b58eb72a6b3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6b1b998bf566abd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/6d35b58eb72a6b3/output.txt

Total script time: 7.28 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/6b1b998bf566abd/output.txt

Total script time: 20.76 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 30d0e3a into mozilla:master May 6, 2024
6 of 7 checks passed
@calixteman calixteman deleted the bug1894849 branch May 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants