Cancel the requestAnimationFrame in the API when cancelling rendering
#18336
Conversation
Errors related to this `requestAnimationFrame` show up intermittently when running the integration-tests on the bots, however I've been unable to reproduce it locally. Hence I cannot guarantee that it's enough to fix the timing issues, however this should be generally safe since the `requestAnimationFrame` invokes the `_next`-method and the first thing that one does is check that rendering hasn't been cancelled.
Snuffleupagus
force-pushed
the
InternalRenderTask-cancel-cancelAnimationFrame
branch
from
c6ffd38
to
a4f1a9a
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/26fa00f82e26d69/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b37b4878b6f1283/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/26fa00f82e26d69/output.txt Total script time: 28.80 mins
Image differences available at: http://54.241.84.105:8877/26fa00f82e26d69/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b37b4878b6f1283/output.txt Total script time: 42.83 mins
Image differences available at: http://54.193.163.58:8877/b37b4878b6f1283/reftest-analyzer.html#web=eq.log |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a26ff72afafb4c6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d31191e5350de57/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a26ff72afafb4c6/output.txt Total script time: 8.14 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d31191e5350de57/output.txt Total script time: 18.69 mins
|
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d47fc26c7be7e7f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a7d085828ebdfaa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a7d085828ebdfaa/output.txt Total script time: 8.18 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d47fc26c7be7e7f/output.txt Total script time: 17.04 mins
|
|
Thanks! |
Errors related to this
requestAnimationFrameshow up intermittently when running the integration-tests on the bots, however I've been unable to reproduce it locally.Hence I cannot guarantee that it's enough to fix the timing issues, however this should be generally safe since the
requestAnimationFrameinvokes the_next-method and the first thing that one does is check that rendering hasn't been cancelled.