Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel the requestAnimationFrame in the API when cancelling rendering #18336

Commits on Jun 26, 2024

  1. Cancel the requestAnimationFrame in the API when cancelling rendering

    Errors related to this `requestAnimationFrame` show up intermittently when running the integration-tests on the bots, however I've been unable to reproduce it locally.
    Hence I cannot guarantee that it's enough to fix the timing issues, however this should be generally safe since the `requestAnimationFrame` invokes the `_next`-method and the first thing that one does is check that rendering hasn't been cancelled.
    Snuffleupagus committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a4f1a9a View commit details
    Browse the repository at this point in the history