Fix spawning excessive conhost processes on Windows #1143
Conversation
|
CI is breaking due to a Rust compiler panic on thirtyfour. Not sure what this is. |
Looks like this |
There was a problem hiding this comment.
Makes sense, thanks for the patch! Let's land this after v0.3.0, because this is no longer an issue-blocking-release and I'd like to avoid re-running the benchmarking tasks with this commit included.
|
Hey, heads up that |
Fixes mozilla#514 (comment) (comment 2022-03-08 by @mitchhentges) Any console-based subprocess spawned with CREATE_NO_WINDOW actually has a hidden console, and thus an associated conhost process. Since the sccache server is already started with CREATE_NO_WINDOW, it's unnecessary to spawn further subprocesses with CREATE_NO_WINDOW. Removing this flag allows subprocesses to share the sccache server's hidden console, thus avoiding each subprocess from getting its own conhost. For an extended explanation see this comment and its follow-ups: mozilla#514 (comment)
sylvestre
force-pushed
the
fix/excessive-conhosts
branch
from
6a68fcc
to
f5d5584
Compare
Codecov Report
@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
- Coverage 35.11% 34.94% -0.18%
==========================================
Files 47 47
Lines 12774 12770 -4
Branches 6637 6635 -2
==========================================
- Hits 4486 4462 -24
- Misses 3986 3988 +2
- Partials 4302 4320 +18
Continue to review full report at Codecov.
|
|
I see you already did the rebase yourself. All good now? |
Fixes mozilla#514 (comment) (comment 2022-03-08 by @mitchhentges) Any console-based subprocess spawned with CREATE_NO_WINDOW actually has a hidden console, and thus an associated conhost process. Since the sccache server is already started with CREATE_NO_WINDOW, it's unnecessary to spawn further subprocesses with CREATE_NO_WINDOW. Removing this flag allows subprocesses to share the sccache server's hidden console, thus avoiding each subprocess from getting its own conhost. For an extended explanation see this comment and its follow-ups: mozilla#514 (comment)
Fixes #514 (comment) (comment 2022-03-08 by @mitchhentges)
Any console-based subprocess spawned with CREATE_NO_WINDOW actually has a hidden console, and thus an associated conhost process. Since the sccache server is already started with CREATE_NO_WINDOW, it's unnecessary to spawn further subprocesses with CREATE_NO_WINDOW. Removing this flag allows subprocesses to share the sccache server's hidden console, thus avoiding each subprocess from getting its own conhost.
For an extended explanation see this comment and its follow-ups:
#514 (comment)