Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spawning excessive conhost processes on Windows #1143

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix spawning excessive conhost processes on Windows #1143

merged 1 commit into from
May 20, 2022

Commits on May 6, 2022

  1. Fix spawning excessive conhost processes on Windows 

    Fixes mozilla#514 (comment) (comment 2022-03-08 by @mitchhentges)

Any console-based subprocess spawned with CREATE_NO_WINDOW actually has a hidden console, and thus an associated conhost process. Since the sccache server is already started with CREATE_NO_WINDOW, it's unnecessary to spawn further subprocesses with CREATE_NO_WINDOW. Removing this flag allows subprocesses to share the sccache server's hidden console, thus avoiding each subprocess from getting its own conhost.

For an extended explanation see this comment and its follow-ups:
mozilla#514 (comment)
    @FooBarWidget @sylvestre
    FooBarWidget authored and sylvestre committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f5d5584 View commit details
    Browse the repository at this point in the history