Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switchPipe() #69

Merged
merged 7 commits into from
Sep 5, 2020
Merged

switchPipe() #69

merged 7 commits into from
Sep 5, 2020

Conversation

mrWh1te
Copy link
Owner

@mrWh1te mrWh1te commented Sep 4, 2020

- replaced forEach() with reduce()
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          563       596   +33     
  Branches       142       152   +10     
=========================================
+ Hits           563       596   +33     
Impacted Files Coverage Δ
src/botmation/actions/inject.ts 100.00% <ø> (ø)
src/botmation/helpers/abort.ts 100.00% <ø> (ø)
src/botmation/types/abort-line-signal.ts 100.00% <ø> (ø)
src/botmation/actions/assembly-lines.ts 100.00% <100.00%> (ø)
src/botmation/actions/pipe.ts 100.00% <100.00%> (ø)
src/botmation/actions/utilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e72a6f...861240c. Read the comment docs.

- moved pipeCase()() into Pipe BotAction's from Utilities
- moved tests accordingly
- tweaked pipeCase()() for callback's to set function as value instead
  of evaluated value (always true) - prob more interested in the index
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mrWh1te mrWh1te mentioned this pull request Sep 5, 2020
50 tasks
@mrWh1te mrWh1te merged commit 6dd013d into master Sep 5, 2020
@mrWh1te mrWh1te deleted the switch-pipe branch September 5, 2020 01:33
@mrWh1te mrWh1te added this to the v2.1 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant