-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1.0 #20
Merged
Merged
v2.1.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
- code, examples, helpers
- botactions, conditionalbotactions, selectors - link to linkedin example - note on in dev likeAllFrom() with link for more information on current dev progress
- polish sites/linkedin a little
- composed instead of custom
- code smells, vulnerabilities, bugs, tech debt, code duplications
|
for linkedin feed export const likeAllFrom = (...peopleNames: string[]): BotAction =>
pipe()(
getFeedPosts(),
forAll()(
post => switchPipe(post)(
pipeCases(postIsUserArticle, postIsAuthoredByAPerson(...peopleNames))(
// scroll to post necessary to click off page link? ie click anchor link (new scrollTo() "navigation" BotAction?)
// the feature, auto-scroll, was added to `page.click()` but in a later Puppeteer version, irc
like(post)
),
abort(),
// pipeCases(postIsUserComment, commentIsAuthoredByAPerson(...peopleNames))(
// likeComment(post)
// ),
// abort()
)
)
) |
- code and link to example - updated function with 2nd param in new pr at botmation
- code and example link
- code and example links
- included as helper
- updated, replaced functions for recent update
- conditionalcallback's
- code, aborting logic/table, link to example - some explanation
- code with explanations for aborting behavior of each
- updated errors code too
|
- abortlinesignal behavior explanations - moved sleep() function into navigation helpers
- added notes to Switch Pipe with links, and reminder that they are separate BotAction's that don't depend on each other, but they tap into unique behavior when composed together - ConditionalCallback interface with basic explanation
- cases signal, switch pipe aborting behavior
- toc wip - trying to get the important content on there - future iterations to polish/improve readability
|
remove from install page note about version to reduce maintenance or set a variable for printing version? |
- sites may hold more value to majority visitors who are probably new
- consistent across docs site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort Line Signal Update mrWh1te/Botmation#66
Advanced Topic page
responsibility of the assemblers to implement (how to use pipe/chain etc, differences between the two)Abort()
Expand on Advanced Conditional's page with pipeCase'ing
pipeCase()() from PR mrWh1te/Botmation#68
matches-> cases, etc)pipeCases()() from PR mrWh1te/Botmation#75
switchPipe()() from PR mrWh1te/Botmation#69
pipeCase()()
new botactions from PR mrWh1te/Botmation#75
Update Site/Linkedin with new botactions and changes from PR mrWh1te/Botmation#75
b4 merge
Future
Botmation (main repo)