Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.0 #20

Merged
merged 36 commits into from
Sep 14, 2020
Merged

v2.1.0 #20

merged 36 commits into from
Sep 14, 2020

Conversation

mrWh1te
Copy link
Owner

@mrWh1te mrWh1te commented Aug 27, 2020

  • v2.0.x -> v2.1
  • api/Scrapers
    • code
    • examples
  • sites/Instagram
    • selectors
  • sites/LinkedIn
    • selectors
    • example - linked
    • code (botaction's, helpers)
  • improve sites/* toc
    • auth section for related auth functions
    • navigation section for related navigation functions
    • etc
  • sites/overview
    • consolidated intro for all sites (separate npm modules, subject to random breakage on site app changes, etc)
    • post-poned for v3 release when it's helpful to explain how each are their own npm packages, as of now, there is little value in creating a separate page to introduce 2 sites
  • forAll()() extended abilities
    • pipe in collection
    • the callback is to be extended with additional params
    • piping assembled looped BotAction's with pipe value matching params of callback except wrapped in array
  • wait() moved into Navigation
  • screenshotAll() no longer custom, but composition

Abort Line Signal Update mrWh1te/Botmation#66

  • Advanced Topic page

    • can use botaction or generate your own signal to return using the helper function, in any of your BotAction's
    • responsibility of the assemblers to implement (how to use pipe/chain etc, differences between the two)
      • left out since it may over complicate things
    • counting assembledLines to break
    • maybe mention the abort line signal in the introduction of botaction? no, leave in advanced
    • update code for utilities, errors, and assembly lines
  • Abort()

    • code
    • example(s)
    • helpers
  • Expand on Advanced Conditional's page with pipeCase'ing

    • CasesSignal
    • switchPiping behavior with pipeCase(s) and abort

pipeCase()() from PR mrWh1te/Botmation#68

  • code
  • examples
  • helpers (matches -> cases, etc)

pipeCases()() from PR mrWh1te/Botmation#75

  • code
  • examples
  • helpers (cases, etc)

switchPipe()() from PR mrWh1te/Botmation#69

new botactions from PR mrWh1te/Botmation#75

  • scrollTo()
  • evaluate()
  • abortPipe()

Update Site/Linkedin with new botactions and changes from PR mrWh1te/Botmation#75

  • feed
  • navigation
  • etc

b4 merge

  • update roadmap
  • review/polish

Future

  • npm install separate modules
  • this code is yet published, but given docs style, can be shared here and later published

Botmation (main repo)

  • readme update, include scrapers & abort

- added link to sidebar, and laid out outline
@mrWh1te mrWh1te added the enhancement New feature or request label Aug 27, 2020
- code, examples, helpers
- botactions, conditionalbotactions, selectors
- link to linkedin example
- note on in dev likeAllFrom() with link for more information on current
  dev progress
@mrWh1te mrWh1te changed the title v2.1.0 v2.1.x Aug 28, 2020
- polish sites/linkedin a little
- composed instead of custom
- code smells, vulnerabilities, bugs, tech debt, code duplications
@mrWh1te
Copy link
Owner Author

mrWh1te commented Aug 31, 2020

See mrWh1te/Botmation#66

  • new Abort Signal as an advanced or getting started topic
  • Abort BotAction
    • code
    • example

@mrWh1te mrWh1te changed the title v2.1.x v2.1.0 Aug 31, 2020
@mrWh1te
Copy link
Owner Author

mrWh1te commented Sep 9, 2020

for linkedin feed

export const likeAllFrom = (...peopleNames: string[]): BotAction => 
  pipe()(
    getFeedPosts(),
    forAll()(
      post => switchPipe(post)(
        pipeCases(postIsUserArticle, postIsAuthoredByAPerson(...peopleNames))(
          // scroll to post necessary to click off page link? ie click anchor link (new scrollTo() "navigation" BotAction?)
          // the feature, auto-scroll, was added to `page.click()` but in a later Puppeteer version, irc
          like(post)
        ),
        abort(),
        // pipeCases(postIsUserComment, commentIsAuthoredByAPerson(...peopleNames))(
        //   likeComment(post)
        // ),
        // abort()
      )
    )
  )

@mrWh1te mrWh1te mentioned this pull request Sep 10, 2020
3 tasks
- code and link to example
- updated function with 2nd param in new pr at botmation
- code and example link
- code and example links
- included as helper
- updated, replaced functions for recent update
- conditionalcallback's
- code, aborting logic/table, link to example
- some explanation
- code with explanations for aborting behavior of each
- updated errors code too
@mrWh1te
Copy link
Owner Author

mrWh1te commented Sep 11, 2020

  • review advanced pages for BotAction interfaces that may have changed slightly

- abortlinesignal behavior explanations
- moved sleep() function into navigation helpers
- added notes to Switch Pipe with links, and reminder that they are
  separate BotAction's that don't depend on each other, but they tap
  into unique behavior when composed together
- ConditionalCallback interface with basic explanation
- cases signal, switch pipe aborting behavior
- toc wip
- trying to get the important content on there
- future iterations to polish/improve readability
@mrWh1te
Copy link
Owner Author

mrWh1te commented Sep 12, 2020

  • examples page needs Linkedin example
    • delayed until linkedin site code published

@mrWh1te
Copy link
Owner Author

mrWh1te commented Sep 12, 2020

remove from install page note about version to reduce maintenance

or set a variable for printing version?

- sites may hold more value to majority visitors who are probably new
- consistent across docs site
@mrWh1te mrWh1te merged commit dea5584 into master Sep 14, 2020
@mrWh1te mrWh1te deleted the v2-1-update branch September 14, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant