Fix switchPipe()() bug, missing edge-cases & cleaner code #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tdd, need to update code to make these pass
- tests passing - abortlinesignal, matchessignal, and regular pipeValues returned are supported - includes unique abortlinesignal/matchessignal behavior - may expand upon testing even though coverage is at 100%
mrWh1te
added
bug
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 596 601 +5
Branches 152 154 +2
=========================================
+ Hits 596 601 +5
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes switchPipe()()'s behavior with abort line signal and fixes the bug with the matches signal
TDD for the win 🎯
Fix issue #71
Related #71 (comment), #71 (comment)