Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecalGeometry: Transform normal with normal matrix #29476

Merged
merged 2 commits into from
Sep 24, 2024
Merged

DecalGeometry: Transform normal with normal matrix #29476

merged 2 commits into from
Sep 24, 2024

Conversation

WestLangley
Copy link
Collaborator

transformDirection() should not be applied to normal vectors, unless under certain conditions. The normal map should be applied, instead.

@WestLangley WestLangley added this to the r169 milestone Sep 23, 2024
@WestLangley
Copy link
Collaborator Author

Related: Is there a reason decals are added to the scene in webgl_decals.html, instead of to the mesh to which they are applied?

Currently, if the mesh is rotated, the decals do not.

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 23, 2024

In webgl_decals, transformDirection() is also used in checkIntersection() to transform normals. Does it make sense to update this code as well?

three.js/examples/webgl_decals.html

Line 191 in 19e79dc

n.transformDirection( mesh.matrixWorld );

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 23, 2024

Is there a reason decals are added to the scene in webgl_decals.html, instead of to the mesh to which they are applied?

Not that I am aware of. It would seem more natural to add the decals to the logical parent object.

@Mugen87 Mugen87 merged commit 8f765f9 into mrdoob:dev Sep 24, 2024
11 checks passed
@WestLangley WestLangley deleted the dev-decals branch September 24, 2024 16:42
@WestLangley
Copy link
Collaborator Author

@Mugen87 Doing mesh.attach( decal ) instead of scene.add( decal ) works well, although .attach() only supports a uniformly-scaled parent mesh (the case here). Do you think such a change to the example is worth it?

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 24, 2024

Yes, using attach() looks like a nicer workflow.

@WestLangley WestLangley mentioned this pull request Sep 24, 2024
Merged
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 27, 2024
@JordanLane-Veerum @LD2Studio
Update Three.js r169
0b04f12 
BatchedMesh: add `deleteInstance()` (mrdoob#29449)

* BatchedMesh: add `deleteInstance()`

* BatchedMesh: prioritize reusing freed instance ids when adding instance

Update Three.js r169

Lensflare: Add WebGPU version. (mrdoob#29451)

* lensflare example

* fix depth

* remove forceWebGL

* rename

* fix typo

* follow original code

* Update LensflareMesh.js

---------

Co-authored-by: aardgoose <[email protected]>
Co-authored-by: Michael Herzog <[email protected]>

Examples: Update lensflare colors. (mrdoob#29458)

WebGLRenderer: add reverse-z via EXT_clip_control (mrdoob#29445)

* WebGLRenderer: add reverse-z via EXT_clip_control

* WebGLRenderer: move conversion methods to utils

Updated builds.

Docs: Improve `WebGLRenderer` page. (mrdoob#29459)

WebGLProgram: add USE_REVERSEDEPTHBUF define (mrdoob#29461)

CylinderGeometry: Don't add degenerate triangles (mrdoob#29460)

* CylinderGeometry: Don't add degenerate triangles

* Change comparison

RenderObject: Introduce `getGeometryCacheKey()` (mrdoob#29465)

* RenderObject: Added `getGeometryCacheKey()`

* NodeMaterialObserver: Improve skinnedmesh and morph supports

* cleanup

Update actions/setup-node digest to 0a44ba7 (mrdoob#29466)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update github/codeql-action digest to 294a9d9 (mrdoob#29467)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update devDependencies (non-major) (mrdoob#29468)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Updated builds.

CurveModifierGPU: WebGPURenderer port. (mrdoob#29453)

* curve mod

* lint

* update screenshot

* use correct constant

* use filtered texture

---------

Co-authored-by: aardgoose <[email protected]>

Examples: Clean up. (mrdoob#29473)

* Examples: Clean up.

* E2E: Update screenshot.

SpriteNodeMaterial: Add sizeAttenuation (mrdoob#29394)

* SpriteNodeMaterial: Add sizeAttenuation

* Regenerate screenshot

* revert mat4 mul with vec4(,1)?

* revert

* using let and toVar fixes the issue?

* merge upstream/dev

* revert screenshot

* does reverting SpriteNode even fix?

* revert fix

* revert everything fix tsl galaxy?

* checkout dev SpriteNodeMaterial.js...

* smaller change test

* convert scale to var

* convert scale to var

* simply adding toVar breaks tsl_galaxy?

* fix multiple spritematerial with different center position

* feedbacks

* cleanup

* feedbacks

* cleanup

* cleanup

---------

Co-authored-by: sunag <[email protected]>

WebGPURenderer: Prevent out of bounds `textureLoad` access in WGSL (mrdoob#29470)

Co-authored-by: aardgoose <[email protected]>

SkyMesh,WaterMesh: Fix NodeMaterial imports (mrdoob#29477)

WebGPURenderer: Reuse LightNode when available (mrdoob#29480)

* WebGPURenderer: Reuse LightNode when available

* cleanup

DecalGeometry: Transform normal with normal matrix (mrdoob#29476)

* Transform normal with normal matrix

* Transform normal with normal matrix

Examples: add reflection mask in `retargeting_readyplayer` (mrdoob#29485)

BatchedMesh: Add `getGeometryRangeAt` (mrdoob#29409)

* BatchedMesh: Add getGeometryRangeAt

Co-authored-by: Luigi Denora <[email protected]>

* Fix eslint error

Co-authored-by: Luigi Denora <[email protected]>

* Doc changed

* Add optional target

---------

Co-authored-by: Luigi Denora <[email protected]>

WebGPURenderer: Introduce hash-based cache key (mrdoob#29479)

* introduce numeric cache key

* cleanup

* cleanup

* simplification

* revision

* rev

* rev

* cleanup

Nodes: Access Remaining Compute Builtins (mrdoob#29469)

* init

* remove duplicated function

Add decal as child of mesh (mrdoob#29486)

Update webgl_postprocessing_ssaa.html

Update webgpu_postprocessing_ssaa.html

ToonOutlinePassNode: Add FX pass for toon outlines. (mrdoob#29483)

* ToonOutlineNode: Add FX pass for toon outlines.

* ToonOutlinePassNode: Refactor code.

* E2E: Update screenshot.

* ToonOutlinePassNode: Clean up.

* ToonOutlinePassNode: More clean up.

* ToonOutlinePassNode: More clean up.

Update Addons.js (mrdoob#29493)

leftovers after removing `PackedPhongMaterial ` mrdoob#29382

ReferenceNode: Fix null reference using `getNodeType()` (mrdoob#29498)

* fix null reference using `getNodeType()`

* add `sprite.center` check

NodeBuilder: Introduce `addFlowCodeHierarchy()` / `NodeBlock` (mrdoob#29495)

* VolumeNodeMaterial: simplify a little

* cleanup

* NodeBuilder: Introduce `addFlowCodeHierarchy()`

Examples: Improve shadow map size in `webgpu_tsl_angular_slicing` (mrdoob#29499)

WebGPURenderer: respect the `renderer.shadowMap.enabled` property (mrdoob#29492)

* enable/disable shadow

* enable shadowmaps

* enable more examples

* and another one

* Update Nodes.js

---------

Co-authored-by: aardgoose <[email protected]>

Updated builds.

GLTFLoader: Remove deprecated code. (mrdoob#29502)

TiltLoader: Remove loader. (mrdoob#29471)

Update Chinese translation of InstancedMesh. (mrdoob#29506)

r169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r169
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @Mugen87