-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dependency toml
to tomllib
#50
Conversation
Keen eye on the Let's keep the python 3.11 checks and if/else import statements out. That adds complexity and would require a multi-python-version testing environment which we'll want to avoid. Juice ain't worth the squeeze. This is a very simple feature--just read/write a toml file, we don't want to add complexity to the package to save a tiny package install for 3.11 users. For merge see my review comments in the code, specifically:
Thanks for the maintenance! Any questions lemme know ❤️ P.S. - Also squash your commits so there is only 1 commit after you make these changes. Google a how-to. If you need help let me know :) |
Thanks for the quick review!
I am following the suggestions from the authors (here and here) for the compatibility layer. I would say that it's OK to trust the maintainer for the consistency between
Binary mode is required by the Let me know your decisions and I will make one final squash commit. |
Thanks for the links to the documentation! Ok I'm persuaded by the compatibility layer for 3.11 and the So to finish this up we need a to add a 3.11 environment to the CI GitHub pipeline to ensure correctness and functionality for python 3.11+. Let's finish up with this:
I'll take it from there and merge and release a new version. Thank you! |
Also, please rebase from |
6ab106e
to
d89c31e
Compare
… against Python 3.8 & 3.11
d89c31e
to
5f85105
Compare
Done! Let me know if there is any additional concern. |
Very professional! Looks great! Congrats on your first PR contribution |
Released to PyPi as |
Reasons for the migration:
hukkin/tomli
has been accepted as part of the Python standard library (see PEP680), named astomllib
, and it is available since Python 3.11.uiri/toml
has not been active since 2020, whilehukkin/tomli
is an actively maintained implementation of TOML 1.0 spec, with 100% test coverage.