-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add new customized switch examples #26096
[docs] Add new customized switch examples #26096
Conversation
I will update the iOS Example as well to more closely resemble the "real" iOS switch control. Another question: I don't know how to fix the remaining failing test. What has to be done to fix it? |
Great!
We will just approve the new screenshot in the end, no need for fixing anything :) |
For iOS, see #25985 (comment) |
9809262
to
673626b
Compare
Looks awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DanielBretzigheimer! It's a great first PR on Material-UI 👌
I have quite struggled to implement this. It took me more time than I had anticipated. @siriwatknp did his share too in https://mui-treasury.com/styles/switch/. @DanielBretzigheimer I wonder how we could simplify the customization of the component. A few thoughts:
|
I fully agree with you on the input part. Clearing up the DOM Structure seems like a good Idea, using a IconButton was confusing for me. I will have a look into it and will try to find a better solution. Should I append the changes to this PR or create another one? Also, this will certainly be a breaking change, but this seems to be okay? |
@DanielBretzigheimer If you can explore this in another pull-request, it would be awesome. I have linked the two relevant issues in my previous comment. As for this PR, no, it's already larger than it needs to be, no more :). |
Added Android 12 switch and custom icon in thumb example to the docs
Issue: #25919
Fix #25985
Preview: https://deploy-preview-26096--material-ui.netlify.app/components/switches/#customized-switches