[Switch] simplify structure WIP #26303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Details of bundle changes (experimental) @material-ui/core: parsed: +0.24% , gzip: +0.28% |
github-actions
bot
added
the
PR: out-of-date
|
@DanielBretzigheimer What do you think the next step should be? |
|
Sorry, had no time this week, but I will look into it tomorrow |
DanielBretzigheimer
force-pushed
the
switch-improvements
branch
from
d0c728a
to
3f5d400
Compare
github-actions
bot
removed
the
PR: out-of-date
DanielBretzigheimer
force-pushed
the
switch-improvements
branch
from
3f5d400
to
853d63c
Compare
|
@oliviertassinari I have added the ripple effect and some other UI improvements today. I also applied your suggestions. The useFormControl is still on my agenda. I will look into it in the following days when I have time. |
1 task
|
@DanielBretzigheimer can you take a look at #26460. The PR simplify the structure of SwitchBase by replacing IconButton with ButtonBase (remove 1 level of DOM). If it is enough, we can hold this PR and improve later. |
github-actions
bot
added
the
PR: out-of-date
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to address the complications from this comment. The PR isn't nearly finished, but I wanted to receive early feedback before changing too much in the code.
One thing I'm not sure about is if the SwitchBase should be removed. It clearly cleans the structure but will duplicate some code.
@oliviertassinari What do you think?
Comparison of the DOM structures:
Old
New
